Commit Graph
29 Commits
Author SHA1 Message Date
Simon Kitching fe9bc1bc5f Utility class for users of commons-logging in webapps.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190896 13f79535-47bb-0310-9956-ffa450edef68
2005-06-16 11:02:47 +00:00
Simon Kitching 70458b7b6e Add an implementation of ServletContextListener for use in avoiding memory leaks in webapps.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190891 13f79535-47bb-0310-9956-ffa450edef68
2005-06-16 09:59:40 +00:00
Simon Kitching 2b9b9b6f24 Add version into jarname as done by maven, eg commons-logging-1.x.x.jar
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190888 13f79535-47bb-0310-9956-ffa450edef68
2005-06-16 09:23:03 +00:00
Simon Kitching c563002215 Create commons-logging-adapters.jar file in dist target.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190887 13f79535-47bb-0310-9956-ffa450edef68
2005-06-16 08:06:43 +00:00
Simon Kitching a843d5dbc0 Build commons-logging-adapters.jar from maven build.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190866 13f79535-47bb-0310-9956-ffa450edef68
2005-06-16 04:10:24 +00:00
Simon Kitching 9ecd27bf48 Fixed copy-and-paste error in getConfigurationValue when getting from system property.
Thanks to Brian Stansberry for spotting this.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190581 13f79535-47bb-0310-9956-ffa450edef68
2005-06-14 11:09:44 +00:00
Simon Kitching b35e8d3b53 Avoid wrapping exception - patch by Brian Stansberry
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190569 13f79535-47bb-0310-9956-ffa450edef68
2005-06-14 10:23:08 +00:00
Simon Kitching a3f8e5302a Merge in the allow-flawed branch, as there were no objections.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190565 13f79535-47bb-0310-9956-ffa450edef68
2005-06-14 10:03:48 +00:00
Simon Kitching ca0188c41e Fix bug introduced by recent changes. Thanks to Brian Stansberry for the patch.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@180287 13f79535-47bb-0310-9956-ffa450edef68
2005-06-06 10:33:37 +00:00
Simon Kitching d7f774a5bb Syntactic cleanups only:
* javadoc layout cleanup
 * variable & param renames


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179572 13f79535-47bb-0310-9956-ffa450edef68
2005-06-02 10:41:12 +00:00
Simon Kitching 17c6d98369 Remove ugly LOG_INTERFACE string and weird log-class-lookup code
from within the reportInvalidLogAdapter method.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179571 13f79535-47bb-0310-9956-ffa450edef68
2005-06-02 10:28:35 +00:00
Simon Kitching eb93a324e4 Clean up LoadTest testcase and include in standard test suite.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179566 13f79535-47bb-0310-9956-ffa450edef68
2005-06-02 09:12:24 +00:00
Simon Kitching d71598bd0f Exclude package.html files from the jar files.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179559 13f79535-47bb-0310-9956-ffa450edef68
2005-06-02 08:35:54 +00:00
Simon Kitching ac7a0f8505 Changed createLogFromClass method to return null on recoverable failure,
and only throw an exception on unrecoverable failure. This simplifies
the code a fair bit.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179546 13f79535-47bb-0310-9956-ffa450edef68
2005-06-02 07:39:39 +00:00
Simon Kitching 5c06195efb Ensure an ExceptionInInitializerError occurs when trying to create an instance
of these classes in pre-1.4 JVMs. Without this, an InvocationTargetException
could be thrown when calling the constructor but that could also be caused
by a number of other reasons which we don't want to ignore.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179529 13f79535-47bb-0310-9956-ffa450edef68
2005-06-02 06:31:52 +00:00
Simon Kitching df0d0ed341 Ensure class files generated are compatible with 1.1 JVMs
(although we only support 1.2+ at the moment).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179511 13f79535-47bb-0310-9956-ffa450edef68
2005-06-02 05:05:18 +00:00
Simon Kitching 15956fee82 Change to discovery process: testing whether various logging
libraries are available is now done by trying to actually
create an instance.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179500 13f79535-47bb-0310-9956-ffa450edef68
2005-06-02 04:09:16 +00:00
Simon Kitching 195ac37a76 Add better reporting when jdk14 handler setup isn't right.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@177867 13f79535-47bb-0310-9956-ffa450edef68
2005-05-23 01:41:23 +00:00
Simon Kitching 75c8135c03 Fix javadoc and fix java1.5 compile warnings.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@177071 13f79535-47bb-0310-9956-ffa450edef68
2005-05-23 01:04:54 +00:00
Simon Kitching a408e51f46 Ensure class file format is compatible with JVM 1.1
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@176581 13f79535-47bb-0310-9956-ffa450edef68
2005-05-23 01:02:02 +00:00
Simon Kitching a04edd5ec6 Updated obsolete goal java:jar to jar:jar
Removed obsolete exclude of CVS subdirs


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@176497 13f79535-47bb-0310-9956-ffa450edef68
2005-05-23 01:01:36 +00:00
Simon Kitching 110f2a234b Added internal diagnostics
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@171301 13f79535-47bb-0310-9956-ffa450edef68
2005-05-22 10:43:52 +00:00
Simon Kitching c485c20b1e Added internal diagnostics
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@171300 13f79535-47bb-0310-9956-ffa450edef68
2005-05-22 10:43:06 +00:00
Simon Kitching c1f16b5d2a Just moved some code out of method getLogConstructor into its own
method reportInvalidLogAdapter to make code easier to read (esp.
as I'm going to add more code to this method later).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@170512 13f79535-47bb-0310-9956-ffa450edef68
2005-05-17 04:27:57 +00:00
Simon Kitching e985f2a051 Minor AccessController-related tidyups:
* Use static initialiser block to initialise factories rather than variable initialiser.
* Add static member thisClassLoader to cache classloader for the LogFactory class;
  change all calls to LogFactory.class.getClassLoader() to just use thisClassLoader.
* Change getContextClassLoader to always use AccessController (actually, rename
  getContextClassLoader to directGetContextClassLoader, and make getContextClassLoader
  a wrapper around that).
* define a method getClassLoader(clazz) that just does clazz.getClassLoader for now;
  change all calls to clazz.getClassLoader into getClassLoader(clazz)


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@170501 13f79535-47bb-0310-9956-ffa450edef68
2005-05-17 01:43:32 +00:00
Simon Kitching 0a54560d5c oops .. should have added myself to the developers list before doing any commits.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@170367 13f79535-47bb-0310-9956-ffa450edef68
2005-05-16 11:41:35 +00:00
Simon Kitching 851f7c5f33 Simple rearrangement of code only; no functionality change (though the diffs don't show that clearly).
Turned a complicated anonymous class declaration into a simple anonymous class that calls a method
on LogFactory containing all the code previously within the anonymous class declaration.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@170355 13f79535-47bb-0310-9956-ffa450edef68
2005-05-16 10:41:44 +00:00
Simon Kitching 3200e8aa2e Add test case for situation where context classloader is null.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@169388 13f79535-47bb-0310-9956-ffa450edef68
2005-05-10 00:47:03 +00:00
Simon Kitching 7839295a8e Fix for case where classloader key to "factories" member is null.
This can happen in JDK1.1 and in embedded systems work. Without this
fix, a new LogFactoryImpl is created each time LogFactory.getLog(..)
is called! See bugzilla#10825, comment#22. Thanks to Erik Erskine for
bug report and fix.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@169387 13f79535-47bb-0310-9956-ffa450edef68
2005-05-10 00:45:18 +00:00