Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity

Fixed innaccurate catch. Should catch all throwables to ensure graceful failure.

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@156998 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Robert Burrell Donkin
2005-03-10 21:55:38 +00:00
parent 23df003ef1
commit 0721445959
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/java/org/apache/commons/logging/LogFactory.java
View File

@@ -34,7 +34,7 @@ import java.util.Properties;
* <p>Factory for creating {@link Log} instances, with discovery and * <p>Factory for creating {@link Log} instances, with discovery and
* configuration features similar to that employed by standard Java APIs * configuration features similar to that employed by standard Java APIs
* such as JAXP.</p> * such as JAXP.</p>
* *
* <p><strong>IMPLEMENTATION NOTE</strong> - This implementation is heavily * <p><strong>IMPLEMENTATION NOTE</strong> - This implementation is heavily
* based on the SAXParserFactory and DocumentBuilderFactory implementations * based on the SAXParserFactory and DocumentBuilderFactory implementations
* (corresponding to the JAXP pluggability APIs) found in Apache Xerces.</p> * (corresponding to the JAXP pluggability APIs) found in Apache Xerces.</p>
@@ -232,7 +232,7 @@ public abstract class LogFactory {
Class implementationClass = Class.forName(storeImplementationClass); Class implementationClass = Class.forName(storeImplementationClass);
result = (Hashtable) implementationClass.newInstance(); result = (Hashtable) implementationClass.newInstance();
} catch (Exception e) { } catch (Throwable t) {
// ignore // ignore
if (!WEAK_HASHTABLE_CLASSNAME.equals(storeImplementationClass)) { if (!WEAK_HASHTABLE_CLASSNAME.equals(storeImplementationClass)) {
// if the user's trying to set up a custom implementation, give a clue // if the user's trying to set up a custom implementation, give a clue