From 072144595926600d34719575c266d2dbeafcc24b Mon Sep 17 00:00:00 2001 From: Robert Burrell Donkin Date: Thu, 10 Mar 2005 21:55:38 +0000 Subject: [PATCH] Fixed innaccurate catch. Should catch all throwables to ensure graceful failure. git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@156998 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/commons/logging/LogFactory.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/java/org/apache/commons/logging/LogFactory.java b/src/java/org/apache/commons/logging/LogFactory.java index 6a86511..500fbe6 100644 --- a/src/java/org/apache/commons/logging/LogFactory.java +++ b/src/java/org/apache/commons/logging/LogFactory.java @@ -34,7 +34,7 @@ import java.util.Properties; *

Factory for creating {@link Log} instances, with discovery and * configuration features similar to that employed by standard Java APIs * such as JAXP.

- * + * *

IMPLEMENTATION NOTE - This implementation is heavily * based on the SAXParserFactory and DocumentBuilderFactory implementations * (corresponding to the JAXP pluggability APIs) found in Apache Xerces.

@@ -232,7 +232,7 @@ public abstract class LogFactory { Class implementationClass = Class.forName(storeImplementationClass); result = (Hashtable) implementationClass.newInstance(); - } catch (Exception e) { + } catch (Throwable t) { // ignore if (!WEAK_HASHTABLE_CLASSNAME.equals(storeImplementationClass)) { // if the user's trying to set up a custom implementation, give a clue