1
0
Commit Graph

1616 Commits

Author SHA1 Message Date
Gary Gregory
82d61a586a Configure SpotBugs 2023-11-26 15:22:36 -05:00
Gary Gregory
087b3cba93 Use Checkstyle ParenPad 2023-11-26 15:07:37 -05:00
Gary Gregory
fa2dd91b6d Javadoc 2023-11-26 15:07:16 -05:00
Gary Gregory
1a30b658bd Use Checkstyle ParenPad 2023-11-26 15:06:34 -05:00
Gary Gregory
1290cecf73 Deprecate
org.apache.commons.logging.impl.Jdk13LumberjackLogger.dummyLevel without
replacement
2023-11-26 15:04:55 -05:00
Gary Gregory
768c5ee741 Javadoc
Normalize spelling
2023-11-26 15:02:35 -05:00
Gary Gregory
c1bee804fc Javadoc
Normalize spelling
2023-11-26 14:58:54 -05:00
Gary Gregory
6777344670 Remove obsolete comment 2023-11-26 14:36:05 -05:00
Gary Gregory
a164386b2a Fix SpotBugs [ERROR] Medium
Switch statement found in
org.apache.commons.logging.impl.SimpleLog.log(int, Object, Throwable)
where default case is missing
[org.apache.commons.logging.impl.SimpleLog] At SimpleLog.java:[lines
505-522] SF_SWITCH_NO_DEFAULT
2023-11-26 14:17:02 -05:00
Gary Gregory
e8a558b708 Spelling and version 1.3.0 2023-11-26 13:51:14 -05:00
Gary Gregory
4b13fdaf94 Remove code that accounts for Java 1.1 and 1.2
Didn't get quite right in the previous commit
2023-11-26 10:42:56 -05:00
Gary Gregory
5ddba2b9f9 Remove code that accounts for Java 1.1 and 1.2 2023-11-26 10:29:45 -05:00
Gary Gregory
8ed85820ce Use try-with-resources 2023-11-26 10:22:37 -05:00
Gary Gregory
a1c174c086 Use try-with-resources 2023-11-26 10:18:14 -05:00
Gary Gregory
6400cd0bc0 Fix generics compiler warnings 2023-11-26 10:15:02 -05:00
Gary Gregory
f80e102dde Remove extra blank lines 2023-11-26 10:08:31 -05:00
Gary Gregory
b7bca0f8cc Remove trailing whitespace 2023-11-26 10:03:58 -05:00
Gary Gregory
98a23a7980 Use varargs 2023-11-26 10:03:51 -05:00
Gary Gregory
d3c1bb95b9 Remove duplicate 2023-11-26 10:01:54 -05:00
Gary Gregory
ed83294439 Set java.logging as optional module #183. 2023-11-25 15:30:05 -05:00
Piotr P. Karwasz
80b2f78eb9 Set java.logging as optional module (#183)
Commons Logging has a fallback simple logger that is used if the
`java.util.logging` package is not present.

Originally this only could happen with Java 1.3, but sinc Java 9 the
user can disable the `java.logging` JPMS module. Commons Logging will
work anyway.

This PR slightly modifies the inherited Moditect configuration to add a
`static` (i.e. optional) modifier to the `java.logging` module.
2023-11-25 15:29:00 -05:00
Gary Gregory
a28caba95b Spelling 2023-11-25 12:33:33 -05:00
Gary Gregory
409ff88dd7 Fix compiler warnings 2023-11-25 12:20:42 -05:00
Gary Gregory
170957c6f6 Spelling
Remove unused import
2023-11-25 12:18:01 -05:00
Gary Gregory
09e85b177c Simplify weird code 2023-11-25 12:16:31 -05:00
Gary Gregory
a5b6ec6522 Fix SpotBugs [ERROR] 2023-11-25 12:12:50 -05:00
Gary Gregory
0f16cc12da Internal refactoring 2023-11-25 12:06:13 -05:00
Gary Gregory
eb9e4c506f Fix SpotBugs [ERROR]
Medium: Class org.apache.commons.logging.impl.WeakHashtable defines non-transient non-serializable instance field queue [org.apache.commons.logging.impl.WeakHashtable] In WeakHashtable.java SE_BAD_FIELD
2023-11-25 11:59:17 -05:00
Gary Gregory
0f25dd6c0e Fix SpotBugs [ERROR]
High: Found reliance on default encoding in org.apache.commons.logging.LogFactory.initDiagnostics(): new java.io.PrintStream(OutputStream) [org.apache.commons.logging.LogFactory] At LogFactory.java:[line 1205] DM_DEFAULT_ENCODING.
2023-11-25 11:55:22 -05:00
Gary Gregory
b9785548d6 Enable PMD check in default Maven goal 2023-11-25 11:41:45 -05:00
Gary Gregory
1b1879d35d Bump commons-parent from 64 to 65 2023-11-25 11:18:26 -05:00
Gary Gregory
afb295013d Remove trailing whitespace 2023-11-25 11:09:13 -05:00
Gary Gregory
5c371bcbbd Organize imports 2023-11-25 11:08:11 -05:00
Gary Gregory
942b1c37af Sort members 2023-11-25 11:07:56 -05:00
Piotr P. Karwasz
35427e2ce7 Disable Lumberjack and Log4j 1.x and document it (#182)
This PR removes Lumberjack and Log4j 1.x for the automatic logging
backend discovery procedure.

The updated procedure is documented in the guide.

This closes LOGGING-173 and LOGGING-188.
2023-11-25 11:06:46 -05:00
dependabot[bot]
2a1457cb34 Bump github/codeql-action from 2.22.7 to 2.22.8 (#181)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.7 to 2.22.8.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](66b90a5db1...407ffafae6)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-24 07:33:51 -05:00
Gary Gregory
64ea85b0ca Checkstyle: @author tags are deprecated 2023-11-23 08:53:54 -05:00
Gary Gregory
e4d94ff51e Spelling 2023-11-20 19:22:47 -05:00
Gary Gregory
6b11d8ab2e Spelling in comments 2023-11-20 09:58:59 -05:00
Gary Gregory
51a3978280 Fix compiler warning 2023-11-20 09:54:16 -05:00
Gary Gregory
5360b9cf84 Better local name 2023-11-20 09:49:42 -05:00
Gary Gregory
0899b5bd2b Fix compiler warning 2023-11-20 09:48:00 -05:00
Gary Gregory
68a33abb85 Remove extra whitespace 2023-11-20 09:46:41 -05:00
Gary Gregory
d262d0986e Document empty blocks 2023-11-20 09:46:16 -05:00
Gary Gregory
6e6b27c957 Document empty blocks 2023-11-20 09:45:25 -05:00
Gary Gregory
2ea4f44d2f Document empty blocks 2023-11-20 09:45:03 -05:00
Gary Gregory
c265c9d46e Deprecate org.apache.commons.logging.impl.WeakHashtable without
replacement.
2023-11-20 09:43:37 -05:00
Gary Gregory
0467d4151a Refactor to local variable 2023-11-20 08:58:24 -05:00
Gary Gregory
7e340b5d73 Better error messages 2023-11-20 08:56:47 -05:00
Gary Gregory
2039eeba6f Fix compiler warnings 2023-11-19 16:33:27 -05:00