1
0
Commit Graph

1500 Commits

Author SHA1 Message Date
Craig R. McClanahan
a6ec91bec0 Remove attempt to configure the root logger if it has not been done so.
* Out of scope for commons-logging, which promises only to wrap
  USE of the logging implementation, not configuration.

* Incorrect assumption that not having appenders configured on the
  root logger is an error.

* Log4J will auto-configure itself if a log4j.xml or log4j.properties
  file is present, so out-of-the-box use with no code is as simple
  as dropping a properties file in the correct place.

PR:  Bugzilla #13201
Submitted by: Steven Caswell <stevencaswell at apache.org>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138966 13f79535-47bb-0310-9956-ffa450edef68
2003-04-02 01:29:38 +00:00
Craig R. McClanahan
7c71a7d917 Wrapper:
- Refactor the setup of class loaders so that it is clearer what is
  going on
- For the Log4J tests, add the custom Appender implementation to
  whichever class loader Log4J is put in
- Set and reset the thread context class loader to more accurately
  simulate the environment of a servlet container.

build.xml:
- Implement the multi-classloader test scenarios for Log4J, equivalent
  to those for JDK 1.4.

We now have a robust testing environment to catch any possible regressions
when modifying the functionality (such as ripping out Log4jFactory, as
discussed on COMMONS-DEV).

I don't have time to do the corresponding test scenarios for Avalon LogKit,
but anyone who wants to do so is welcome to create them.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138965 13f79535-47bb-0310-9956-ffa450edef68
2003-04-02 00:50:49 +00:00
Craig R. McClanahan
5347bd9e55 Copy LICENSE.txt file into distribution, and make sure it is included in the
JAR files, without going to the directory above the top-level directory.
This will make it easier to build commons-logging from source distros.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138964 13f79535-47bb-0310-9956-ffa450edef68
2003-03-31 00:38:22 +00:00
Craig R. McClanahan
c12099176f If we are not going to log the message anyway, do not waste the effort
to create a Throwable and figure out the calling class and method stuff.

PR:  Bugzilla #18184
Submitted by:  Bruno Dumon <bruno at outerthought.org>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138963 13f79535-47bb-0310-9956-ffa450edef68
2003-03-31 00:27:08 +00:00
Craig R. McClanahan
b3039e1bbf When copying MANIFEST.MF files for the JAR files, use the one that has
already been filtered to get the right version number in it.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138962 13f79535-47bb-0310-9956-ffa450edef68
2003-03-31 00:20:19 +00:00
Craig R. McClanahan
27559f2f8c Cosmetic changes, and correct copyright dates. Add simple overview
with pointer to the real documentation, and a package.html for the
o.a.c.l.impl package.  Bring various documentation points up to date
with the actual current functionality.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138961 13f79535-47bb-0310-9956-ffa450edef68
2003-03-30 23:42:36 +00:00
Craig R. McClanahan
e462bae3af Add basic tests for Log4J. Still need to add the multi-classloader
scenarios.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138960 13f79535-47bb-0310-9956-ffa450edef68
2003-03-30 05:22:50 +00:00
Craig R. McClanahan
4ed6819dc3 Add test scenarios where two levels of class loader hierarchies are created -
one exactly like the default configuration of Tomcat 4.1 (with c-l placed
inside the webapp) and one where you put c-l in the parent class loader
(in place of commons-logging-api.jar) so webapps do not have to.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138959 13f79535-47bb-0310-9956-ffa450edef68
2003-03-30 02:30:37 +00:00
Craig R. McClanahan
916223fc8d Add a more thorough set of unit tests for using JDK 1.4 logging. Right now,
the tests run when everything is in the system class loader -- need to add
execution wrappers for two-tier class loaders where:

  * commons-logging.jar is in the parent and test execution is in the child

  * commons-logging-api.jar is in the parent and test execution plus
    commons-logging.jar is in the child

to simulate container environments like that you get running inside Tomcat.

Later on, we'll want an analogous set of tests for Log4J.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138958 13f79535-47bb-0310-9956-ffa450edef68
2003-03-29 22:04:54 +00:00
Craig R. McClanahan
64fc246f30 Clean up JavaDoc warning on JDK 1.4.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138957 13f79535-47bb-0310-9956-ffa450edef68
2003-03-29 18:31:17 +00:00
Craig R. McClanahan
cf2cfe7196 Avoid breaking the build when a developer has "commons-logging.jar" set
in a build.properties file already.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138956 13f79535-47bb-0310-9956-ffa450edef68
2003-03-17 03:24:14 +00:00
Costin Manolache
0f011cbf65 That's what was breaking the build in tomcat5.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138955 13f79535-47bb-0310-9956-ffa450edef68
2003-03-13 21:19:33 +00:00
baliuka
21932779c8 Added tests for class loading, no problems detected in "common" use cases
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138954 13f79535-47bb-0310-9956-ffa450edef68
2003-03-01 09:55:07 +00:00
Craig R. McClanahan
7b532cd48c Update the build process to skip all the Log4J implementation classes
if Log4J is not present.

PR:  Bugzilla #16358
Submitted by:  Jeremias Maerki <jeremias at apache.org>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138952 13f79535-47bb-0310-9956-ffa450edef68
2003-02-01 04:29:05 +00:00
Craig R. McClanahan
f7faef2426 Change the class used to detect whether JDK 1.4 is installed from
"java.util.logging.Logger" to "java.sql.Savepoint".  This means
that a JDK 1.3 JVM with an alternative JSR-47 (logging jsr) implementation
available will not be mis-identified as a JDK 1.4 system.

PR:  Bugzilla #16606
Submitted by:  Andreas Wendt <wen at eigner.com>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138951 13f79535-47bb-0310-9956-ffa450edef68
2003-02-01 04:11:03 +00:00
Henri Yandell
9e8e6b4991 Upgraded the dependency from 1.1.3 to 1.2.6.
Possibly it ought to move to 1.2.7, but I'm unable to confirm if Maven
has that in the repository at the moment.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138950 13f79535-47bb-0310-9956-ffa450edef68
2003-01-24 18:39:53 +00:00
Craig R. McClanahan
9f33f5482d Experimentally add a release(ClassLoader) method that lets, for example,
a webapp clean up references to any LogFactory, and associated Log
instances, that are associated with its class loader.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138948 13f79535-47bb-0310-9956-ffa450edef68
2002-12-18 07:20:50 +00:00
Richard A. Sitze
27b1f756e3 Oops.. almost broke type check via typecast!
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138947 13f79535-47bb-0310-9956-ffa450edef68
2002-12-13 16:55:39 +00:00
Richard A. Sitze
d256cb00f7 More doPriv's around ClassLoader.loadClass and Class.forName
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138946 13f79535-47bb-0310-9956-ffa450edef68
2002-12-13 16:48:06 +00:00
Richard A. Sitze
7117827bcb Fix getResourceAsStream security violations with doPriv.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138945 13f79535-47bb-0310-9956-ffa450edef68
2002-12-12 20:29:16 +00:00
Robert Burrell Donkin
4f6bc55f0e Added a FAQ entry about thread safety based on a paragraph suggested by John Yu.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138944 13f79535-47bb-0310-9956-ffa450edef68
2002-12-12 19:56:44 +00:00
Richard A. Sitze
6daa5b9439 Duh. Different take on this - why do we preload in the first place?
New methods check System & local properties directly.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138943 13f79535-47bb-0310-9956-ffa450edef68
2002-12-12 19:49:30 +00:00
Richard A. Sitze
b122313d94 1. Wrapped System.getProperties with doPrivileged.
2. Moved catch.  If System properties cannot be loaded,
    then don't abandon effort, but go on to loading
    properties file.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138942 13f79535-47bb-0310-9956-ffa450edef68
2002-12-12 19:23:34 +00:00
Craig R. McClanahan
4e0ad3c8ff It helps if you actually add the new file as well.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138941 13f79535-47bb-0310-9956-ffa450edef68
2002-11-23 03:50:13 +00:00
Craig R. McClanahan
2783ad6bc1 Deprecte Log4JCategoryLog (because Log4J has deprecated o.a.l.Category),
and replace it with a new Log4JLogger implementation that wraps an
o.a.l.Logger instance instead.

Update docco to reflect that Log4J support is now for version 1.2 or later
(when o.a.l.Logger was introduced).

PR:  13118
Submitted by:  Paul Campbell <seapwc at halycon.com>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138940 13f79535-47bb-0310-9956-ffa450edef68
2002-11-23 03:49:40 +00:00
Craig R. McClanahan
e0be9b7850 Add a getCategory() method that returns the underlying Log4J Category
instance, analogous to the getLogger() method on JDK14Logger.

PR:  Bugzilla 14155
Submitted by:  Chris Hagmann <ch at ipin.com>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138939 13f79535-47bb-0310-9956-ffa450edef68
2002-11-23 03:25:33 +00:00
Craig R. McClanahan
03645a6b4a Update remaining documentation that says the default Log implementation
is NoOpLog.  It was changed to SimpleLog a while back.

PR:  Bugzilla #14571
Submitted by:  David M. Karr <dmkarr@earthlink.net>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138938 13f79535-47bb-0310-9956-ffa450edef68
2002-11-23 03:07:58 +00:00
Richard A. Sitze
a661c64c6d *** empty log message ***
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138937 13f79535-47bb-0310-9956-ffa450edef68
2002-11-11 16:52:54 +00:00
Dion Gillard
c4cefe5632 Ignore logs
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138936 13f79535-47bb-0310-9956-ffa450edef68
2002-11-01 03:25:56 +00:00
Dion Gillard
4ed0fed1c8 Woops
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138935 13f79535-47bb-0310-9956-ffa450edef68
2002-11-01 03:25:43 +00:00
Dion Gillard
3b71f2efc9 Added logs
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138934 13f79535-47bb-0310-9956-ffa450edef68
2002-11-01 03:24:08 +00:00
Rodney Waldhoff
478b89b021 inceptionYear is 2001
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138933 13f79535-47bb-0310-9956-ffa450edef68
2002-10-31 16:18:15 +00:00
Dion Gillard
1e48b00b78 Fix typo - thanks Martin
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138932 13f79535-47bb-0310-9956-ffa450edef68
2002-10-31 03:49:33 +00:00
Dion Gillard
84fb63cf44 Fix URL
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138931 13f79535-47bb-0310-9956-ffa450edef68
2002-10-31 03:03:37 +00:00
Craig R. McClanahan
4453cfb4fa Avoid name clashes on local property names "commons-logging-api.jar" and
"commons-logging.jar" which will not work correctly for any developer who
has such properties defined in a "${user.home}/build.properties" file.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138930 13f79535-47bb-0310-9956-ffa450edef68
2002-10-28 00:41:29 +00:00
Costin Manolache
8daf0f8bce A small change that allows the quick build of commons-logging jars.
The way I use it is:
   <ant dir="${cvs.base}/jakarta-commons/logging" target="compile-only" >
       <property name="commons-logging-api.jar" location="${build.dir}/lib/commons-logging-api.jar" />
        <property name="commons-logging.jar" location="${build.dir}/lib/commons-logging.jar" />
        <property name="build.home" value="${build.dir}" />
    </ant>

If it brakes something or any other problem - please let me know.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138929 13f79535-47bb-0310-9956-ffa450edef68
2002-10-24 18:26:21 +00:00
Richard A. Sitze
41a175c6bd typo - slap me for not building/testing after EVERY minor change..
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138928 13f79535-47bb-0310-9956-ffa450edef68
2002-10-19 17:38:06 +00:00
Richard A. Sitze
3a5b034cef - code cleanup, refactoring, and corrected a few undiscoved bugs..
- Bugzilla 13157 - Log4j takes undue precedence over Log override.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138927 13f79535-47bb-0310-9956-ffa450edef68
2002-10-19 17:25:18 +00:00
Richard A. Sitze
f76f188696 Dump stack trace through logger, not stdout
(preservers sequence of buffered output).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138926 13f79535-47bb-0310-9956-ffa450edef68
2002-10-19 17:19:05 +00:00
Richard A. Sitze
dfcf03ab41 - Added new LogTest that exercises factory
- log statements now show implementation class
   (helpfull for visual verification that expected logger was found).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138925 13f79535-47bb-0310-9956-ffa450edef68
2002-10-19 17:14:26 +00:00
Sean Sullivan
a3566a19b7 added null parameter log method calls
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138924 13f79535-47bb-0310-9956-ffa450edef68
2002-10-18 04:19:56 +00:00
Richard A. Sitze
03368dd582 Bugzilla Defect 10825 [thanks for the patch & the education!]
Added real text & exceptions to tests.. it's harder to read :-(


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138923 13f79535-47bb-0310-9956-ffa450edef68
2002-10-17 23:00:04 +00:00
Sean Sullivan
8c5d183b40 removed junk methods
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138922 13f79535-47bb-0310-9956-ffa450edef68
2002-10-11 05:02:59 +00:00
Sean Sullivan
398e84d1b6 added test code
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138921 13f79535-47bb-0310-9956-ffa450edef68
2002-10-11 04:53:21 +00:00
Sean Sullivan
3bd953f430 unit test code
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138920 13f79535-47bb-0310-9956-ffa450edef68
2002-10-11 04:52:59 +00:00
Robert Burrell Donkin
4f4e1d7a3c Updated STATUS document with release information.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138919 13f79535-47bb-0310-9956-ffa450edef68
2002-09-27 18:39:12 +00:00
Richard A. Sitze
72e4cef37b javadoc cleanup
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138917 13f79535-47bb-0310-9956-ffa450edef68
2002-09-27 02:16:44 +00:00
Richard A. Sitze
c53d47efc9 javadoc cleanup
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138916 13f79535-47bb-0310-9956-ffa450edef68
2002-09-27 02:14:57 +00:00
Richard A. Sitze
b891e01d0c Version 1.0.2
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138915 13f79535-47bb-0310-9956-ffa450edef68
2002-09-27 02:02:06 +00:00
Richard A. Sitze
fd531862b1 Adding self as contributor.. only thing new here is updating the doc.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138914 13f79535-47bb-0310-9956-ffa450edef68
2002-09-25 22:06:19 +00:00