1
0
Commit Graph

365 Commits

Author SHA1 Message Date
Simon Kitching
cfb31332a1 * Fix bug where unit tests weren't getting executed at all (wrong test class name)
* Put both resources in child classloader rather than using parent, to avoid
  confusion with parentFirst not being supported by PathableClassLoader.getResources.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394603 13f79535-47bb-0310-9956-ffa450edef68
2006-04-17 03:30:38 +00:00
Simon Kitching
93cd3bf810 Add comment about getResources not respecting parentFirst
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394564 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 21:30:57 +00:00
Simon Kitching
f32ae813fc Remove recently-added implementation of getResources. As javadoc already stated,
this can't be implemented because in java 1.4 getResources is final :-(. Unit
tests that care about getResources() order will just have to use parentFirst=true.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394563 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 21:30:19 +00:00
Simon Kitching
21d9e3c157 Fix dumb double-test. Thanks to Dennis Lundberg for pointing this out.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394560 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 21:20:21 +00:00
Simon Kitching
1f32b55765 Improve diagnostics
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394467 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 12:15:30 +00:00
Simon Kitching
ef627680ff Improve diagnostic output
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394466 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 12:11:05 +00:00
Simon Kitching
0ad40253d6 Handle case of null parent classloader
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394463 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 12:01:57 +00:00
Simon Kitching
76cc63f74c Improve diagnostics
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394462 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 11:43:29 +00:00
Simon Kitching
1c67c2510f Fix bug where priority of first commons-logging.properties file found was ignored.
Also improve diagnostics output.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394461 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 11:36:37 +00:00
Simon Kitching
3555fbc436 Add unit test to verify that priority of first-found config file is respected
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394460 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 11:35:22 +00:00
Simon Kitching
4cebeec80f Update javadoc only
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394459 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 11:34:33 +00:00
Simon Kitching
77abea9d19 Fix error where getResources() would return parent items first, even when
parentFirst attribute was set to false.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394457 13f79535-47bb-0310-9956-ffa450edef68
2006-04-16 11:27:11 +00:00
Robert Burrell Donkin
be29881f14 Preparing for release candidate 8
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@392752 13f79535-47bb-0310-9956-ffa450edef68
2006-04-09 15:09:17 +00:00
Robert Burrell Donkin
378b7205b8 Preparations for release candidate 7.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@392033 13f79535-47bb-0310-9956-ffa450edef68
2006-04-06 18:53:50 +00:00
Robert Burrell Donkin
12db408e92 Upgraded manifest to reflect upcoming release candidate.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@386164 13f79535-47bb-0310-9956-ffa450edef68
2006-03-15 21:06:38 +00:00
Robert Burrell Donkin
dfbafcfb30 Improved diagnostics and added more information to the message thrown when a custom LogFactory cannot be loaded due to classloader incompatibilities.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@384025 13f79535-47bb-0310-9956-ffa450edef68
2006-03-07 21:54:57 +00:00
Simon Kitching
7870118ec9 Another minor diagnostics tweak.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381887 13f79535-47bb-0310-9956-ffa450edef68
2006-03-01 03:15:40 +00:00
Simon Kitching
d6dfbd01eb * Fix minor syntax error in previous checkin (oops).
* Improve error message when custom LogFactory class cannot be instantiated due
to class cast issues.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381886 13f79535-47bb-0310-9956-ffa450edef68
2006-03-01 03:11:41 +00:00
Simon Kitching
497c9ae5f1 Add a diagnostic message, and add some comments related to issues when a
LogFactory implementation cannot be instantiated.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381879 13f79535-47bb-0310-9956-ffa450edef68
2006-03-01 02:49:34 +00:00
Simon Kitching
08cd79161b Trivial javadoc patch to add return type info for isXXXEnabled methods.
Thanks to Boris Unckel for patch; see bugzilla#38783.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381838 13f79535-47bb-0310-9956-ffa450edef68
2006-02-28 23:57:11 +00:00
Simon Kitching
eb89dd6405 Diagnostics changes only:
* Output correct classloader used to load LogFactory implementation
* Use word "from" instead of confusing "->"
* Other minor improvements to diagnostics messages.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381828 13f79535-47bb-0310-9956-ffa450edef68
2006-02-28 23:32:27 +00:00
Simon Kitching
dc5a557622 Minor diagnostics tweak: use word "from" instead of confusion "->".
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381826 13f79535-47bb-0310-9956-ffa450edef68
2006-02-28 23:31:20 +00:00
Simon Kitching
f336788e71 Add Serializable tests for NoOpLog.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381239 13f79535-47bb-0310-9956-ffa450edef68
2006-02-27 03:07:41 +00:00
Simon Kitching
0806aa3672 Move NoOp tests into separate directory.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381238 13f79535-47bb-0310-9956-ffa450edef68
2006-02-27 02:59:47 +00:00
Simon Kitching
f3a21723bc Execute tests from base AbstractLogTest class in addition to existing tests.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381237 13f79535-47bb-0310-9956-ffa450edef68
2006-02-27 02:59:11 +00:00
Simon Kitching
037499be30 Add comments, clean up imports.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381236 13f79535-47bb-0310-9956-ffa450edef68
2006-02-27 02:58:24 +00:00
Simon Kitching
d88846ee06 Add unit tests for the LogKitLogger.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381234 13f79535-47bb-0310-9956-ffa450edef68
2006-02-27 02:39:54 +00:00
Simon Kitching
bdec71cc5a Minor enhancement to diagnostic message.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381224 13f79535-47bb-0310-9956-ffa450edef68
2006-02-27 02:28:39 +00:00
Simon Kitching
a6d1f7c256 Removed Serializable marker interface as it is not possible to implement this
correctly in all cases. AvalonLogger was introduced in 1.0.4, and was marked
Serializable. However serialization for this class was *completely* broken in
all cases in that release, so removing the Serializable marker is not considered
a binary-incompatible change.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@379680 13f79535-47bb-0310-9956-ffa450edef68
2006-02-22 04:53:08 +00:00
Robert Burrell Donkin
22822656d2 Preparing for release candidate 5.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@378363 13f79535-47bb-0310-9956-ffa450edef68
2006-02-16 20:53:27 +00:00
Robert Burrell Donkin
bf61edb4c3 Reverted 375631 (null getParent). After discussions about the relevant javadocs, it was established that the interpretation which lead to this patch is probably wrong. The original implementation supplies null to Class.forName which should create the class from the boot loader.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377868 13f79535-47bb-0310-9956-ffa450edef68
2006-02-14 22:38:07 +00:00
Robert Burrell Donkin
b03846809e Improved diagnostic message by adding quotes.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377237 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 20:25:13 +00:00
Robert Burrell Donkin
271a6784d2 Improved diagnostic message by adding quotes.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377235 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 20:23:13 +00:00
Robert Burrell Donkin
6b8f983f0d Improved diagnostic message.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377234 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 20:20:03 +00:00
Robert Burrell Donkin
5106722c82 Improved diagnostic message.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377232 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 20:17:33 +00:00
Robert Burrell Donkin
42488ff8df Improved diagnostic message.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377231 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 20:15:17 +00:00
Robert Burrell Donkin
c68be0fed3 Added guards around diagnostic logging. Is unlikely to have much effect on real life performance but is good practice and should stop questions.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377229 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 20:01:28 +00:00
Robert Burrell Donkin
7c807d78c7 Added diagnostic logging for security exceptions.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377202 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:39:40 +00:00
Robert Burrell Donkin
5d1fcf3662 Added quotes to diagnostic messages.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377201 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:34:53 +00:00
Robert Burrell Donkin
a62f12925f Fix typo, changed some colons to dashes (colons overused) and added some quotes.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377200 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:31:21 +00:00
Robert Burrell Donkin
4b315332db Print classloader details when the class loaded is incompatible. Added comment suggesting fix.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377199 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:28:32 +00:00
Robert Burrell Donkin
b765938bfe Added single quote around class name and corrected capitalization.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377198 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:20:29 +00:00
Robert Burrell Donkin
6f52ab12b1 Prefixed environmental diagnostic content with [ENV].
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377197 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:18:07 +00:00
Robert Burrell Donkin
5d48ac1008 Added instance OID to prefix for LogFactoryImpl. This allows cross-referencing to details such as the TCCL managed by the instance.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377196 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:09:43 +00:00
Robert Burrell Donkin
b86aad5988 Log hierarchy for TCCL.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377195 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:00:22 +00:00
Robert Burrell Donkin
42266eebbf Prefixed all diagnostic content during LogFactory implementation discovery by [LOOKUP]. This should make it easier for users to link the content together when they analyse the logs.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377194 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 15:41:38 +00:00
Robert Burrell Donkin
22aaea10a4 Factored hierarchical section of environmental diagnostic logging into separate method so that it can be reused.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377192 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 15:36:29 +00:00
Robert Burrell Donkin
28cbe64b0e Sun classloaders typically have very bad toString methods. Others (for example, IDM classloaders) output useful information. Added toString call which may be very useful in the latter case.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377189 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 15:07:32 +00:00
Robert Burrell Donkin
cc01f0f023 A lot of colons are used in the diagnostic logs. Changed to use [INFO] in this case since it fits better with usage elsewhere.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377187 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 14:55:14 +00:00
Robert Burrell Donkin
d2fcbd4b36 Changed private method name to better reflect current purpose.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377186 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 14:53:40 +00:00