1
0
Commit Graph

359 Commits

Author SHA1 Message Date
Simon Kitching
110f2a234b Added internal diagnostics
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@171301 13f79535-47bb-0310-9956-ffa450edef68
2005-05-22 10:43:52 +00:00
Simon Kitching
c485c20b1e Added internal diagnostics
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@171300 13f79535-47bb-0310-9956-ffa450edef68
2005-05-22 10:43:06 +00:00
Simon Kitching
c1f16b5d2a Just moved some code out of method getLogConstructor into its own
method reportInvalidLogAdapter to make code easier to read (esp.
as I'm going to add more code to this method later).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@170512 13f79535-47bb-0310-9956-ffa450edef68
2005-05-17 04:27:57 +00:00
Simon Kitching
e985f2a051 Minor AccessController-related tidyups:
* Use static initialiser block to initialise factories rather than variable initialiser.
* Add static member thisClassLoader to cache classloader for the LogFactory class;
  change all calls to LogFactory.class.getClassLoader() to just use thisClassLoader.
* Change getContextClassLoader to always use AccessController (actually, rename
  getContextClassLoader to directGetContextClassLoader, and make getContextClassLoader
  a wrapper around that).
* define a method getClassLoader(clazz) that just does clazz.getClassLoader for now;
  change all calls to clazz.getClassLoader into getClassLoader(clazz)


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@170501 13f79535-47bb-0310-9956-ffa450edef68
2005-05-17 01:43:32 +00:00
Simon Kitching
851f7c5f33 Simple rearrangement of code only; no functionality change (though the diffs don't show that clearly).
Turned a complicated anonymous class declaration into a simple anonymous class that calls a method
on LogFactory containing all the code previously within the anonymous class declaration.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@170355 13f79535-47bb-0310-9956-ffa450edef68
2005-05-16 10:41:44 +00:00
Simon Kitching
3200e8aa2e Add test case for situation where context classloader is null.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@169388 13f79535-47bb-0310-9956-ffa450edef68
2005-05-10 00:47:03 +00:00
Simon Kitching
7839295a8e Fix for case where classloader key to "factories" member is null.
This can happen in JDK1.1 and in embedded systems work. Without this
fix, a new LogFactoryImpl is created each time LogFactory.getLog(..)
is called! See bugzilla#10825, comment#22. Thanks to Erik Erskine for
bug report and fix.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@169387 13f79535-47bb-0310-9956-ffa450edef68
2005-05-10 00:45:18 +00:00
Robert Burrell Donkin
0721445959 Fixed innaccurate catch. Should catch all throwables to ensure graceful failure.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@156998 13f79535-47bb-0310-9956-ffa450edef68
2005-03-10 21:55:38 +00:00
Dirk Verbeeck
b56a58e5de svn:keywords correction
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@155426 13f79535-47bb-0310-9956-ffa450edef68
2005-02-26 13:10:49 +00:00
Robert Burrell Donkin
769564ac45 Reverted some changes which broke backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@153511 13f79535-47bb-0310-9956-ffa450edef68
2005-02-12 14:56:21 +00:00
Robert Burrell Donkin
f87688012a Restricted warning message so that it is only displayed when the property has been set
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@151748 13f79535-47bb-0310-9956-ffa450edef68
2005-02-07 20:36:53 +00:00
Robert Burrell Donkin
7a03f06584 LogFactory's Hashtable implementation (used to store LogFactoryImpl by classloader) can now be subclassed. This will default to WeakHashtable when this is present on the classpath, Hashtable otherwise. The implementation class can be specified by a system property. Based on a contribution by Brian Stansberry.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139056 13f79535-47bb-0310-9956-ffa450edef68
2004-11-10 23:00:47 +00:00
Robert Burrell Donkin
23e71e6d58 Added new optional subcomponent consisting of non-core implementations. Initial contents MemoryLog, a log implementation intended for use when unit testing. Issue #27663. Contributed by Joerg Schaible.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139055 13f79535-47bb-0310-9956-ffa450edef68
2004-11-04 23:03:59 +00:00
Robert Burrell Donkin
b30b048bb7 Workaround for Java 1.2.2 compiler bug. Issue #31818.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139054 13f79535-47bb-0310-9956-ffa450edef68
2004-10-31 17:53:48 +00:00
Craig R. McClanahan
697ba5c648 Remove the deprecated Log4JCategoryLog class, now that the trunk of Log4J
has finally removed the Category class.  In C-L, this has been deprecated
for a very long time, and is replaced (invisibly for most users) by
Log4JLogger.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139053 13f79535-47bb-0310-9956-ffa450edef68
2004-10-29 05:37:59 +00:00
Robert Burrell Donkin
433ad87cd1 Fix addressing null pointer when logging is loaded by boot classloader for JRE's that return a null classloader in this situtation. Issue #31710. Patch contributed by David Ferrero.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139052 13f79535-47bb-0310-9956-ffa450edef68
2004-10-17 09:14:10 +00:00
Robert Burrell Donkin
86b1ee0eab Improved test for log4j availability. Patch from issue #31597
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139051 13f79535-47bb-0310-9956-ffa450edef68
2004-10-17 09:02:48 +00:00
Peter A Royal Jr
7e6c9ff377 Avalon Logger was broken by Serialization changes 13 months ago. Fixing and made not Serializable
since it cannot be Serializable if a Logger is explicitly passed in.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139050 13f79535-47bb-0310-9956-ffa450edef68
2004-09-27 16:21:40 +00:00
Robert Burrell Donkin
c61bf4c76d Java doc improvements. Patch contributed by Dennis Lundberg.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139042 13f79535-47bb-0310-9956-ffa450edef68
2004-06-06 21:16:04 +00:00
Robert Burrell Donkin
5e61a0932e Java doc improvements. Patch contributed by Dennis Lundberg.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139041 13f79535-47bb-0310-9956-ffa450edef68
2004-06-06 20:47:56 +00:00
Robert Burrell Donkin
aff740f629 JavaDoc improvements
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139038 13f79535-47bb-0310-9956-ffa450edef68
2004-06-01 19:56:46 +00:00
Robert Burrell Donkin
ed0269ef72 New test case for simple log date time setting
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139033 13f79535-47bb-0310-9956-ffa450edef68
2004-05-30 10:32:25 +00:00
Robert Burrell Donkin
7e7bf1ad60 Removed unneccessary check introduced by myself.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139032 13f79535-47bb-0310-9956-ffa450edef68
2004-05-30 10:32:06 +00:00
Robert Burrell Donkin
4d10d0df0c Enhanced simple log so that the date and time can be set. Bugzilla issue #27528. Contributed by Dennis Lundberg.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139031 13f79535-47bb-0310-9956-ffa450edef68
2004-05-29 10:43:35 +00:00
Robert Burrell Donkin
3a7e975403 Modifications required to ensure Log4JLogger works with both 1.2.x and 1.3 Log4J. Submitted by Ceki Gulcu.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139029 13f79535-47bb-0310-9956-ffa450edef68
2004-05-19 21:01:23 +00:00
Robert Burrell Donkin
d3ebabcd5d Altered test case so that it will work both with head and 1.2.x of Log4J.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139028 13f79535-47bb-0310-9956-ffa450edef68
2004-05-19 20:59:56 +00:00
Robert Burrell Donkin
444a6b2829 New test case which tests the executation of all the basic methods.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139027 13f79535-47bb-0310-9956-ffa450edef68
2004-05-19 20:58:52 +00:00
Craig R. McClanahan
0421b481aa Tweak the release notes to include the last enhancement.
Update version number to 1.0.4 in both build.xml and MANIFEST.MF (in the
original Ant based build mechanisms, we used to use filter replacement
so you only had to change this in one place; is there some technique to
regain that benefit that works with both Ant and Maven?).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139023 13f79535-47bb-0310-9956-ffa450edef68
2004-03-06 22:20:54 +00:00
Craig R. McClanahan
c69e5fd057 Enhance the error message produced when the isAssignableFrom() check
in getLogConstructor() fails.  If it is due to the fact that o.a.c.l.Log
is visible more than once (the typical cause), say this explicitly.

PR:  Bugzilla #25156.
Submitted by:  Ralf Hauser <hauser AT acm DOT org>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139022 13f79535-47bb-0310-9956-ffa450edef68
2004-03-06 21:52:59 +00:00
Craig R. McClanahan
b7a766054f If an InvocationTargetException is thrown during the construction of a new
Log instance, unwrap it so that the message on the LogConfigurationException
identifies the actual cause of the problem.

PR:  Bugzilla #26598
Submitted By:  Brian Curnow <bcurnow AT gfs DOT com>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139021 13f79535-47bb-0310-9956-ffa450edef68
2004-03-06 21:25:36 +00:00
Craig R. McClanahan
a1b55ec925 Factor the actual writing out of log() into a new write() method so that
subclasses can easily specialize this function, without having to specialize
the creation of the message to be written.

PR:  Bugzilla #27135
Submitted by:  Aaron Hamid <arh14 at cornell.edu>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139016 13f79535-47bb-0310-9956-ffa450edef68
2004-03-01 02:12:48 +00:00
Craig R. McClanahan
37c89a6d88 Make this implementation Serializable as well.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139012 13f79535-47bb-0310-9956-ffa450edef68
2004-02-28 23:05:01 +00:00
Craig R. McClanahan
538ee2bd6d Eliminate spurious second "-" character when showShortLogname=true.
PR:  Bugzilla #25940
Submitted by: Dennis Lundberg <dennis.lundberg at mdh.se>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139011 13f79535-47bb-0310-9956-ffa450edef68
2004-02-28 23:00:57 +00:00
Craig R. McClanahan
d96e2a0af2 Clean up a Javadoc generation warning.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139010 13f79535-47bb-0310-9956-ffa450edef68
2004-02-28 22:16:16 +00:00
Craig R. McClanahan
ef2a5e4383 Finish migration to the new Apache License (version 2.0):
* Add updated LICENSE.txt and new NOTICE.txt files.
* Add license header to currently unlicensed text files
  (html, xml, properties).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139009 13f79535-47bb-0310-9956-ffa450edef68
2004-02-28 22:10:53 +00:00
Craig R. McClanahan
514f666482 Phase 1 of updating [logging] to the Apache License version 2.0. Executed
the "ReplaceLicense" utility in the committers module.  Individual cleanups
and the addition of licenses to currently unlicensed files will follow in
a separate commit.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139008 13f79535-47bb-0310-9956-ffa450edef68
2004-02-28 21:46:46 +00:00
Robert Burrell Donkin
c83a3e1b5a Fixes for typos and speiling mistakes in the javadocs Contributed by Dennis Lundberg.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@139007 13f79535-47bb-0310-9956-ffa450edef68
2004-02-28 17:54:14 +00:00
Timothy O'Brien
4b738b61fc Commit'd a commons logging logo
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138998 13f79535-47bb-0310-9956-ffa450edef68
2004-02-10 02:43:00 +00:00
Robert Burrell Donkin
4d51df78d4 Fixed typos in apache licenses
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138996 13f79535-47bb-0310-9956-ffa450edef68
2003-10-09 21:37:48 +00:00
Robert Burrell Donkin
c81ff3807f Corrected licenses to match jakarta-commons standard.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138995 13f79535-47bb-0310-9956-ffa450edef68
2003-10-05 15:59:26 +00:00
Craig R. McClanahan
2db31c969e Remove "final" declaration on the Log implementations that still have it
(SimpleLog was already non-final) so that developers can subclass to
specialize the existing behavior.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138994 13f79535-47bb-0310-9956-ffa450edef68
2003-10-02 16:17:57 +00:00
Craig R. McClanahan
27c9920b42 Correct a usage example in the Package Description javadocs.
PR:  Bugzilla #18889
Submitted By:  Thai Ha (thaiha at psv.com.vn)


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138993 13f79535-47bb-0310-9956-ffa450edef68
2003-08-16 23:46:31 +00:00
Craig R. McClanahan
a4eb04167c Add support for Lumberjack (a project that supports JSR-47 compatible
logging on a JDK 1.2 or JDK 1.3 system).

PR:  Bugzilla #21455.
Submitted By:  Vince Eagen <vince256 at comcast.net>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138992 13f79535-47bb-0310-9956-ffa450edef68
2003-08-16 22:35:16 +00:00
Craig R. McClanahan
e7c2d81417 Make the remaining non-deprecated Log implementations also implement
Serializable, and enhance the unit tests for JDK 1.4 an Log4J logging
to validate the ability to deserialize and use such instances.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138991 13f79535-47bb-0310-9956-ffa450edef68
2003-08-16 21:58:59 +00:00
Craig R. McClanahan
45c7fb43cb Make o.a.c.l.impl.SimpleLog Serializable.
Add more comprehensive unit tests for SimpleLog, including the ability
to serialize and deserialize instances.

This work will form the basis for making similar changes to the other
Log implementations (and their corresponding test cases).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138990 13f79535-47bb-0310-9956-ffa450edef68
2003-08-16 21:25:54 +00:00
Craig R. McClanahan
7e5ed8d7dd Cosmetic changes only - clean up JDK 1.4.2 javadoc generation warnings.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138989 13f79535-47bb-0310-9956-ffa450edef68
2003-08-16 18:21:50 +00:00
Richard A. Sitze
8ab8f5e09b Cleanup imports.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138987 13f79535-47bb-0310-9956-ffa450edef68
2003-07-18 14:14:16 +00:00
Richard A. Sitze
76e5c8aaf7 Cleanup imports & some static method calls.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138986 13f79535-47bb-0310-9956-ffa450edef68
2003-07-18 14:11:45 +00:00
Craig R. McClanahan
5ac51cd843 Make SimpleLog more friendly to the security manager in an applet
environment, by swallowing any security exceptions when looking
up system properties that are not accessible.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138985 13f79535-47bb-0310-9956-ffa450edef68
2003-07-15 15:47:38 +00:00
Robert Burrell Donkin
7539845c43 Made implementation of AvalonLogger more robust (avoiding NPEs when nulls are passed in) together with a testcase. Improved build by compiling tests for only those optional components whose dependencies are present. Submitted by Neeme Praks.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138983 13f79535-47bb-0310-9956-ffa450edef68
2003-05-14 11:14:24 +00:00