Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity
638 Commits 1 Branch 0 Tags
96291d3b7f5bb57fd846bb790bfcad082d965a96
Commit Graph

237 Commits

Author SHA1 Message Date
Robert Burrell Donkin
cc01f0f023 A lot of colons are used in the diagnostic logs. Changed to use [INFO] in this case since it fits better with usage elsewhere. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377187 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 14:55:14 +00:00
Robert Burrell Donkin
d2fcbd4b36 Changed private method name to better reflect current purpose. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377186 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 14:53:40 +00:00
Robert Burrell Donkin
d1dcf8a3e2 Added single quotes to diagnostic class names to improve readability. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377185 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 14:51:36 +00:00
Robert Burrell Donkin
621dd503a6 Consistent prefixes for diagnostics messages. Reduced length (to make more readable when used in container) by stripping package. Changed LogFactory to use OID for classloader. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377184 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 14:46:03 +00:00
Robert Burrell Donkin
51a1fcbddd Added content prefixes for LogFactory bootstrap diagnostics. Also added message to indicate when the bootstrap has been completed. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377152 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 11:12:11 +00:00
Robert Burrell Donkin
796501a41d Java documentation improvements: added notes about the value of the constants describes where they might be useful to a user. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377058 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-11 21:20:55 +00:00
Robert Burrell Donkin
df4e6edb4a Improved message issued when user specified log class cannot be loaded: when the name is close to that of one of the standard implementations, a hint is provided. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@376454 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-09 22:16:12 +00:00
Simon Kitching
6a015667eb Fix problem where getResources method causes NoSuchMethodError on 1.1 JVMs, 
due to lack of ClassLoader.getResources method. See bugzilla #37484.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@375866 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-08 05:46:03 +00:00
Robert Burrell Donkin
f674577eb8 Added catch and retry using class classloader block. This should hopefully address the cases where the TCCL is not set reasonably. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@375696 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-07 20:48:02 +00:00
Robert Burrell Donkin
41863c3cc8 Please check this long addition carefully. Hopefully the in-code comments should describe the reasons for this change but I'll outline them here as well. ClassLoader#getParent can return null to indicate the bootstrap classloader. Sun's implementations do not but this behaviour might be encountered in other JVMs. I haven't been able to test this patch so please check this very carefully. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@375631 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-07 15:38:22 +00:00
Robert Burrell Donkin
a48c939fe4 Improved diagnostics 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@374538 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-02 22:56:55 +00:00
Robert Burrell Donkin
230500ea51 Improved exception message. This should allow users who add whitespace to easily see that they've made a mistake. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@372295 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-25 19:16:03 +00:00
Simon Kitching
f8d25b3b92 Update javadoc now that WeakHashtable is part of the standard distribution. 
ServletContextCleaner is only a backup for odd corner cases.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371450 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-23 03:18:47 +00:00
Simon Kitching
a341992b05 Fix javadoc to remove references to "optional" jar, as this class is 
now in the main distribution.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371448 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-23 03:10:45 +00:00
Robert Burrell Donkin
506707c7e2 Added @since tags as recommended in the release best practices document. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371403 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-22 22:07:31 +00:00
Dennis Lundberg
80fba3b101 Eliminate javadoc warnings and errors. Issue #38344. Thanks to Rahul Akolkar. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371108 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-21 19:39:46 +00:00
Robert Burrell Donkin
df40010452 Added a note about the reason for this change. Might be useful to those that come after us... 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371089 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-21 17:19:05 +00:00
Simon Kitching
8ba8c0f9ef Fix for java1.2: in that version, Boolean.valueOf(str) returns a new instance 
each time, not one of Boolean.TRUE or Boolean.FALSE!


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370752 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-20 07:45:22 +00:00
Simon Kitching
0077ddf3cd Added comments only. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370738 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-20 05:53:42 +00:00
Simon Kitching
fe23e42c56 Add 2-param version of newFactory method for backwards compatibility. As described in the 
javadoc, it could only ever be invoked by a very weird custom subclass of LogFactory but
it was technically an incompatibility so it's now fixed.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370718 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-20 03:38:04 +00:00
Simon Kitching
7b26b353f7 Fixed javadoc warnings: @param did not match real param name. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370699 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-20 02:29:48 +00:00
Simon Kitching
fc9408a84f Remove Log4J13Logger; log4j 1.3 is not yet released. 
Rename Log4J12Logger back to old name of Log4JLogger.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370672 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-19 23:52:23 +00:00
Robert Burrell Donkin
7fd0e64429 Javadoc improvements. Contributed by Boris Unckel. Issue #38174. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370659 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-19 22:48:16 +00:00
Robert Burrell Donkin
209b1f0688 Javadoc improvements. Contributed by Boris Unckel. Issue #38174. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370654 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-19 22:31:02 +00:00
Robert Burrell Donkin
ec82b0f579 Javadoc improvements. Contributed by Boris Unckel. Issue #38174. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370652 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-19 22:23:48 +00:00
Robert Burrell Donkin
64a4980cc3 Javadoc improvements. Contributed by Boris Unckel. Issue #38174. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370651 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-19 22:12:10 +00:00
Robert Burrell Donkin
1f391b01cf Javadoc improvements. Contributed by Boris Unckel. Issue #38174. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370633 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-19 20:59:36 +00:00
Robert Burrell Donkin
65b0cc351b Javadoc improvements. Contributed by Boris Unckel. Issue #38174. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370631 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-19 20:50:46 +00:00
Robert Burrell Donkin
82703af9c8 Javadoc improvements. Contributed by Boris Unckel. Issue #38174. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370618 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-19 20:32:32 +00:00
Simon Kitching
de40e38a37 Walk the entire hierarchy of ClassLoaders, releasing memory for the 
current webapp from each copy of LogFactory found.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370464 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-19 12:16:56 +00:00
Robert Burrell Donkin
73f2a07e70 Added note into javadocs about the fact that getFactory is not gauranteed to return the same instance per classloader environment. Issue #38026. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370278 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-18 21:57:10 +00:00
Simon Kitching
1b6895e3c5 Add feature to disable loading of Log implementations from the TCCL. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370030 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-18 03:38:38 +00:00
Simon Kitching
89a0e10f95 If config file has use_tccl=false, then don't load LogFactory implementation from the TCCL. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@369745 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-17 10:39:30 +00:00
Simon Kitching
477165adb1 Implement feature to load the commons-logging.properties file with the highest priority value, 
not just the first one found on the classpath.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@369712 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-17 07:56:00 +00:00
Simon Kitching
e934c30030 Simple code cleanup; classloader for LogFactory class is computed once at startup. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@369705 13f79535-47bb-0310-9956-ffa450edef68
 2006-01-17 07:22:21 +00:00
Robert Burrell Donkin
2f2b9d43eb Added WeakHashtable to standard distribution. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@356024 13f79535-47bb-0310-9956-ffa450edef68
 2005-12-11 21:21:10 +00:00
Robert Burrell Donkin
001f359d58 Workaround for buggy reflection. Thanks to Dennis Lundberg for discovering this problem. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@345332 13f79535-47bb-0310-9956-ffa450edef68
 2005-11-17 21:39:26 +00:00
Simon Kitching
b808fe4666 Minor comment fix. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209449 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 12:06:32 +00:00
Simon Kitching
549db6b069 Split Log4JLogger into Log4J12Logger and Log4J13Logger 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@193079 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-23 05:40:32 +00:00
Simon Kitching
60c7478968 Add comments only. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@191652 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-21 11:59:31 +00:00
Simon Kitching
0f272fa209 Issue warning instead of error when ALLOW_FLAWED_CONTEXT is true and the context 
classloader is not related to the classloader used for LogFactoryImpl. This can
happen with JBoss' Unified Classloader approach. See bugzilla#35423.
Thanks to Brian Stansberry for the patch.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@191431 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-20 10:09:51 +00:00
Simon Kitching
e2a17e8fb8 Simplify discovery by using table of classes to check. Also enhance diagnostics a little. 
There are no functional changes in this patch.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@191107 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-17 08:09:22 +00:00
Simon Kitching
fe9bc1bc5f Utility class for users of commons-logging in webapps. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190896 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-16 11:02:47 +00:00
Simon Kitching
9ecd27bf48 Fixed copy-and-paste error in getConfigurationValue when getting from system property. 
Thanks to Brian Stansberry for spotting this.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190581 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-14 11:09:44 +00:00
Simon Kitching
b35e8d3b53 Avoid wrapping exception - patch by Brian Stansberry 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190569 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-14 10:23:08 +00:00
Simon Kitching
a3f8e5302a Merge in the allow-flawed branch, as there were no objections. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190565 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-14 10:03:48 +00:00
Simon Kitching
ca0188c41e Fix bug introduced by recent changes. Thanks to Brian Stansberry for the patch. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@180287 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-06 10:33:37 +00:00
Simon Kitching
d7f774a5bb Syntactic cleanups only: 
* javadoc layout cleanup
 * variable & param renames


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179572 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-02 10:41:12 +00:00
Simon Kitching
17c6d98369 Remove ugly LOG_INTERFACE string and weird log-class-lookup code 
from within the reportInvalidLogAdapter method.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179571 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-02 10:28:35 +00:00
Simon Kitching
ac7a0f8505 Changed createLogFromClass method to return null on recoverable failure, 
and only throw an exception on unrecoverable failure. This simplifies
the code a fair bit.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179546 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-02 07:39:39 +00:00