Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity
1,663 Commits 1 Branch 0 Tags
7b686552c377b4083cba39fa8cc68fb75518ae00
Commit Graph

855 Commits

Author SHA1 Message Date
Simon Kitching
41c4b10250 Major restructure of log4j unit tests. All the same tests are done as before, 
but in a (hopefully) clearer and more maintainable way.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209730 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-08 10:08:25 +00:00
Simon Kitching
8831d63879 Minor tweak to javadocs 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209729 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-08 10:07:13 +00:00
Simon Kitching
9d0c1a7422 Rename LogTest to LogTestCase for consistency. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209713 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-08 07:08:54 +00:00
Simon Kitching
4bd1bd70a0 * renamed test cases from Test.java to TestCase.java for consistency. 
* removed unneeded suite and constructor methods.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209711 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-08 07:02:20 +00:00
Robert Burrell Donkin
d163dc0a8f Tweaked test to improve portability across JVMs. (Added sorting of resource to ensure known order.) 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209642 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-07 20:16:25 +00:00
Robert Burrell Donkin
dfc008fc82 Tweaked test to improve portability across JVMs. (Added sorting of resource to ensure known order.) 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209633 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-07 18:59:21 +00:00
Simon Kitching
3083b9a334 Removed method PathableClassLoader.getResources as in java1.4 and earlier this 
method is final (can't be overridden). This means changing the associated unit
test too. As getResources doesn't explicitly indicate the order in which
resources will be returned this is technically ok, though a little ugly.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209571 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-07 07:32:16 +00:00
Simon Kitching
4c8d747d37 Use custom classloader setups to work around SimpleLog static insanity. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209452 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 12:37:25 +00:00
Simon Kitching
2649aa8c6d Remove unused constructor 
Set necessary System properties in code rather than assuming build.xml will set them.
Call LogFactory.releaseAll before each test for cleanliness.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209451 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 12:09:58 +00:00
Simon Kitching
35b1d6c80e Remove unused constructor, and clear LogFactory.factories cache before each test for cleanliness. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209450 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 12:07:40 +00:00
Simon Kitching
b808fe4666 Minor comment fix. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209449 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 12:06:32 +00:00
Simon Kitching
02ee1e9086 Rename from BadHashtablePropertyTest to BadHashtablePropertyTestCase for consistency. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209420 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 07:18:39 +00:00
Simon Kitching
6ceb7c0ab3 Change to using PathableTestSuite - this permits the test to be significantly simplified. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209419 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 07:17:45 +00:00
Simon Kitching
ac38503d3b Added comments re this class and junit reloadable classloaders. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209418 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 07:14:03 +00:00
Simon Kitching
b69deb90dd Move duplicated testResetContext tests out of ParentFirst and ChildFirst into GeneralTestCase. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209414 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 06:28:24 +00:00
Simon Kitching
c542c21c29 New test case for additional PathableTestSuite functionality. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209413 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 06:26:02 +00:00
Simon Kitching
4a0c892957 Save and restore system properties around tests. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209412 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 06:19:32 +00:00
Simon Kitching
1996c5af1b Renamed AltHashtableTest to AltHashtableTestCase for consistency. 
Also removed unneeded constructor.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209410 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 05:29:57 +00:00
Simon Kitching
1ac4b57165 Rename AvalonLoggerTest to AvalonLoggerTestCase for consistency. 
Also remove unneeded constructor.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209408 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 05:15:39 +00:00
Simon Kitching
85836bd32e JUnit TestCase class has had a default constructor for a long while now, 
so remove pointless constructors for TestCase subclasses.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209407 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-06 05:14:12 +00:00
Simon Kitching
ec7eab0150 Added test cases for child-first behaviour of PathableClassLoader. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209245 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-05 08:50:41 +00:00
Simon Kitching
ab117df3c7 Fix bugs with child-first behaviour. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209244 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-05 08:49:54 +00:00
Simon Kitching
b1f4809445 Renamed to ParentFirstTestCase. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209243 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-05 08:49:03 +00:00
Simon Kitching
773fe5af3c Renamed from PathableTestCase, as it really tests parent-first classloading. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209240 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-05 08:10:19 +00:00
Simon Kitching
184e3781ef Remove unused imports. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209201 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-05 03:42:02 +00:00
Simon Kitching
27d2386598 Added more unit tests. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209198 13f79535-47bb-0310-9956-ffa450edef68
 2005-07-05 03:40:50 +00:00
Simon Kitching
14cd0d8326 Fix copyright statements on new files. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@202474 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-30 03:36:02 +00:00
Simon Kitching
9b59c323f6 Allow testcases to control the classloader hierarchy used during the test. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@202471 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-30 03:21:03 +00:00
Simon Kitching
549db6b069 Split Log4JLogger into Log4J12Logger and Log4J13Logger 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@193079 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-23 05:40:32 +00:00
Simon Kitching
60c7478968 Add comments only. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@191652 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-21 11:59:31 +00:00
Simon Kitching
330e17e0ed The created jarfiles now have the version# embedded in their names, so the 
test wrapper class can't just hard-wire their names any more. Instead, we
pass the jarfile names in from the build.xml file as system properties.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@191630 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-21 06:21:55 +00:00
Simon Kitching
0f272fa209 Issue warning instead of error when ALLOW_FLAWED_CONTEXT is true and the context 
classloader is not related to the classloader used for LogFactoryImpl. This can
happen with JBoss' Unified Classloader approach. See bugzilla#35423.
Thanks to Brian Stansberry for the patch.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@191431 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-20 10:09:51 +00:00
Simon Kitching
e2a17e8fb8 Simplify discovery by using table of classes to check. Also enhance diagnostics a little. 
There are no functional changes in this patch.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@191107 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-17 08:09:22 +00:00
Simon Kitching
fe9bc1bc5f Utility class for users of commons-logging in webapps. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190896 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-16 11:02:47 +00:00
Simon Kitching
9ecd27bf48 Fixed copy-and-paste error in getConfigurationValue when getting from system property. 
Thanks to Brian Stansberry for spotting this.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190581 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-14 11:09:44 +00:00
Simon Kitching
b35e8d3b53 Avoid wrapping exception - patch by Brian Stansberry 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190569 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-14 10:23:08 +00:00
Simon Kitching
a3f8e5302a Merge in the allow-flawed branch, as there were no objections. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@190565 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-14 10:03:48 +00:00
Simon Kitching
ca0188c41e Fix bug introduced by recent changes. Thanks to Brian Stansberry for the patch. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@180287 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-06 10:33:37 +00:00
Simon Kitching
d7f774a5bb Syntactic cleanups only: 
* javadoc layout cleanup
 * variable & param renames


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179572 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-02 10:41:12 +00:00
Simon Kitching
17c6d98369 Remove ugly LOG_INTERFACE string and weird log-class-lookup code 
from within the reportInvalidLogAdapter method.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179571 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-02 10:28:35 +00:00
Simon Kitching
eb93a324e4 Clean up LoadTest testcase and include in standard test suite. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179566 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-02 09:12:24 +00:00
Simon Kitching
ac7a0f8505 Changed createLogFromClass method to return null on recoverable failure, 
and only throw an exception on unrecoverable failure. This simplifies
the code a fair bit.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179546 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-02 07:39:39 +00:00
Simon Kitching
5c06195efb Ensure an ExceptionInInitializerError occurs when trying to create an instance 
of these classes in pre-1.4 JVMs. Without this, an InvocationTargetException
could be thrown when calling the constructor but that could also be caused
by a number of other reasons which we don't want to ignore.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179529 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-02 06:31:52 +00:00
Simon Kitching
15956fee82 Change to discovery process: testing whether various logging 
libraries are available is now done by trying to actually
create an instance.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@179500 13f79535-47bb-0310-9956-ffa450edef68
 2005-06-02 04:09:16 +00:00
Simon Kitching
195ac37a76 Add better reporting when jdk14 handler setup isn't right. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@177867 13f79535-47bb-0310-9956-ffa450edef68
 2005-05-23 01:41:23 +00:00
Simon Kitching
75c8135c03 Fix javadoc and fix java1.5 compile warnings. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@177071 13f79535-47bb-0310-9956-ffa450edef68
 2005-05-23 01:04:54 +00:00
Simon Kitching
110f2a234b Added internal diagnostics 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@171301 13f79535-47bb-0310-9956-ffa450edef68
 2005-05-22 10:43:52 +00:00
Simon Kitching
c485c20b1e Added internal diagnostics 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@171300 13f79535-47bb-0310-9956-ffa450edef68
 2005-05-22 10:43:06 +00:00
Simon Kitching
c1f16b5d2a Just moved some code out of method getLogConstructor into its own 
method reportInvalidLogAdapter to make code easier to read (esp.
as I'm going to add more code to this method later).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@170512 13f79535-47bb-0310-9956-ffa450edef68
 2005-05-17 04:27:57 +00:00
Simon Kitching
e985f2a051 Minor AccessController-related tidyups: 
* Use static initialiser block to initialise factories rather than variable initialiser.
* Add static member thisClassLoader to cache classloader for the LogFactory class;
  change all calls to LogFactory.class.getClassLoader() to just use thisClassLoader.
* Change getContextClassLoader to always use AccessController (actually, rename
  getContextClassLoader to directGetContextClassLoader, and make getContextClassLoader
  a wrapper around that).
* define a method getClassLoader(clazz) that just does clazz.getClassLoader for now;
  change all calls to clazz.getClassLoader into getClassLoader(clazz)


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@170501 13f79535-47bb-0310-9956-ffa450edef68
 2005-05-17 01:43:32 +00:00