Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity
442 Commits 1 Branch 0 Tags
506707c7e2357d873d0f1a139615a25633b6d482
Commit Graph

250 Commits

Author SHA1 Message Date
Craig R. McClanahan
c12099176f If we are not going to log the message anyway, do not waste the effort 
to create a Throwable and figure out the calling class and method stuff.

PR:  Bugzilla #18184
Submitted by:  Bruno Dumon <bruno at outerthought.org>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138963 13f79535-47bb-0310-9956-ffa450edef68
 2003-03-31 00:27:08 +00:00
Craig R. McClanahan
27559f2f8c Cosmetic changes, and correct copyright dates. Add simple overview 
with pointer to the real documentation, and a package.html for the
o.a.c.l.impl package.  Bring various documentation points up to date
with the actual current functionality.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138961 13f79535-47bb-0310-9956-ffa450edef68
 2003-03-30 23:42:36 +00:00
Craig R. McClanahan
e462bae3af Add basic tests for Log4J. Still need to add the multi-classloader 
scenarios.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138960 13f79535-47bb-0310-9956-ffa450edef68
 2003-03-30 05:22:50 +00:00
Craig R. McClanahan
4ed6819dc3 Add test scenarios where two levels of class loader hierarchies are created - 
one exactly like the default configuration of Tomcat 4.1 (with c-l placed
inside the webapp) and one where you put c-l in the parent class loader
(in place of commons-logging-api.jar) so webapps do not have to.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138959 13f79535-47bb-0310-9956-ffa450edef68
 2003-03-30 02:30:37 +00:00
Craig R. McClanahan
916223fc8d Add a more thorough set of unit tests for using JDK 1.4 logging. Right now, 
the tests run when everything is in the system class loader -- need to add
execution wrappers for two-tier class loaders where:

  * commons-logging.jar is in the parent and test execution is in the child

  * commons-logging-api.jar is in the parent and test execution plus
    commons-logging.jar is in the child

to simulate container environments like that you get running inside Tomcat.

Later on, we'll want an analogous set of tests for Log4J.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138958 13f79535-47bb-0310-9956-ffa450edef68
 2003-03-29 22:04:54 +00:00
Craig R. McClanahan
64fc246f30 Clean up JavaDoc warning on JDK 1.4. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138957 13f79535-47bb-0310-9956-ffa450edef68
 2003-03-29 18:31:17 +00:00
baliuka
21932779c8 Added tests for class loading, no problems detected in "common" use cases 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138954 13f79535-47bb-0310-9956-ffa450edef68
 2003-03-01 09:55:07 +00:00
Craig R. McClanahan
f7faef2426 Change the class used to detect whether JDK 1.4 is installed from 
"java.util.logging.Logger" to "java.sql.Savepoint".  This means
that a JDK 1.3 JVM with an alternative JSR-47 (logging jsr) implementation
available will not be mis-identified as a JDK 1.4 system.

PR:  Bugzilla #16606
Submitted by:  Andreas Wendt <wen at eigner.com>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138951 13f79535-47bb-0310-9956-ffa450edef68
 2003-02-01 04:11:03 +00:00
Craig R. McClanahan
9f33f5482d Experimentally add a release(ClassLoader) method that lets, for example, 
a webapp clean up references to any LogFactory, and associated Log
instances, that are associated with its class loader.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138948 13f79535-47bb-0310-9956-ffa450edef68
 2002-12-18 07:20:50 +00:00
Richard A. Sitze
27b1f756e3 Oops.. almost broke type check via typecast! 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138947 13f79535-47bb-0310-9956-ffa450edef68
 2002-12-13 16:55:39 +00:00
Richard A. Sitze
d256cb00f7 More doPriv's around ClassLoader.loadClass and Class.forName 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138946 13f79535-47bb-0310-9956-ffa450edef68
 2002-12-13 16:48:06 +00:00
Richard A. Sitze
7117827bcb Fix getResourceAsStream security violations with doPriv. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138945 13f79535-47bb-0310-9956-ffa450edef68
 2002-12-12 20:29:16 +00:00
Richard A. Sitze
6daa5b9439 Duh. Different take on this - why do we preload in the first place? 
New methods check System & local properties directly.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138943 13f79535-47bb-0310-9956-ffa450edef68
 2002-12-12 19:49:30 +00:00
Richard A. Sitze
b122313d94 1. Wrapped System.getProperties with doPrivileged. 
2. Moved catch.  If System properties cannot be loaded,
    then don't abandon effort, but go on to loading
    properties file.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138942 13f79535-47bb-0310-9956-ffa450edef68
 2002-12-12 19:23:34 +00:00
Craig R. McClanahan
4e0ad3c8ff It helps if you actually add the new file as well. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138941 13f79535-47bb-0310-9956-ffa450edef68
 2002-11-23 03:50:13 +00:00
Craig R. McClanahan
2783ad6bc1 Deprecte Log4JCategoryLog (because Log4J has deprecated o.a.l.Category), 
and replace it with a new Log4JLogger implementation that wraps an
o.a.l.Logger instance instead.

Update docco to reflect that Log4J support is now for version 1.2 or later
(when o.a.l.Logger was introduced).

PR:  13118
Submitted by:  Paul Campbell <seapwc at halycon.com>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138940 13f79535-47bb-0310-9956-ffa450edef68
 2002-11-23 03:49:40 +00:00
Craig R. McClanahan
e0be9b7850 Add a getCategory() method that returns the underlying Log4J Category 
instance, analogous to the getLogger() method on JDK14Logger.

PR:  Bugzilla 14155
Submitted by:  Chris Hagmann <ch at ipin.com>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138939 13f79535-47bb-0310-9956-ffa450edef68
 2002-11-23 03:25:33 +00:00
Craig R. McClanahan
03645a6b4a Update remaining documentation that says the default Log implementation 
is NoOpLog.  It was changed to SimpleLog a while back.

PR:  Bugzilla #14571
Submitted by:  David M. Karr <dmkarr@earthlink.net>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138938 13f79535-47bb-0310-9956-ffa450edef68
 2002-11-23 03:07:58 +00:00
Richard A. Sitze
a661c64c6d *** empty log message *** 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138937 13f79535-47bb-0310-9956-ffa450edef68
 2002-11-11 16:52:54 +00:00
Richard A. Sitze
41a175c6bd typo - slap me for not building/testing after EVERY minor change.. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138928 13f79535-47bb-0310-9956-ffa450edef68
 2002-10-19 17:38:06 +00:00
Richard A. Sitze
3a5b034cef - code cleanup, refactoring, and corrected a few undiscoved bugs.. 
- Bugzilla 13157 - Log4j takes undue precedence over Log override.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138927 13f79535-47bb-0310-9956-ffa450edef68
 2002-10-19 17:25:18 +00:00
Richard A. Sitze
f76f188696 Dump stack trace through logger, not stdout 
(preservers sequence of buffered output).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138926 13f79535-47bb-0310-9956-ffa450edef68
 2002-10-19 17:19:05 +00:00
Richard A. Sitze
dfcf03ab41 - Added new LogTest that exercises factory 
- log statements now show implementation class
   (helpfull for visual verification that expected logger was found).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138925 13f79535-47bb-0310-9956-ffa450edef68
 2002-10-19 17:14:26 +00:00
Sean Sullivan
a3566a19b7 added null parameter log method calls 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138924 13f79535-47bb-0310-9956-ffa450edef68
 2002-10-18 04:19:56 +00:00
Richard A. Sitze
03368dd582 Bugzilla Defect 10825 [thanks for the patch & the education!] 
Added real text & exceptions to tests.. it's harder to read :-(


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138923 13f79535-47bb-0310-9956-ffa450edef68
 2002-10-17 23:00:04 +00:00
Sean Sullivan
8c5d183b40 removed junk methods 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138922 13f79535-47bb-0310-9956-ffa450edef68
 2002-10-11 05:02:59 +00:00
Sean Sullivan
398e84d1b6 added test code 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138921 13f79535-47bb-0310-9956-ffa450edef68
 2002-10-11 04:53:21 +00:00
Sean Sullivan
3bd953f430 unit test code 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138920 13f79535-47bb-0310-9956-ffa450edef68
 2002-10-11 04:52:59 +00:00
Richard A. Sitze
72e4cef37b javadoc cleanup 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138917 13f79535-47bb-0310-9956-ffa450edef68
 2002-09-27 02:16:44 +00:00
Richard A. Sitze
c53d47efc9 javadoc cleanup 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138916 13f79535-47bb-0310-9956-ffa450edef68
 2002-09-27 02:14:57 +00:00
Richard A. Sitze
5b662d1710 Correct 2 problems: 
1. getContextClassLoader is priviledged, protect for J2EE environs.
2. getContextClassLoader can & does return null.  Code wasn't
    checking for this properly.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138913 13f79535-47bb-0310-9956-ffa450edef68
 2002-08-30 03:23:34 +00:00
Richard A. Sitze
5c1867cae3 Correct caching behavior... I broke it a while back, but 
I've learned much since then...


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138907 13f79535-47bb-0310-9956-ffa450edef68
 2002-08-12 21:01:07 +00:00
Richard A. Sitze
21e56ae851 Subtle little bug... if we cannot find OUR Log4J wrapper, then 
we cannot support Log4j...


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138904 13f79535-47bb-0310-9956-ffa450edef68
 2002-08-09 18:47:34 +00:00
Richard A. Sitze
75d031c682 Compatible change, reveal internal properties that are useful for 
discovery...  ?should discovery use reflection to try to find these,
in absence of explicitly provided values?


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138903 13f79535-47bb-0310-9956-ffa450edef68
 2002-08-09 16:18:36 +00:00
Richard A. Sitze
52ba50f028 bug 10480: handle null message without throwing NPE 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138897 13f79535-47bb-0310-9956-ffa450edef68
 2002-07-17 16:42:40 +00:00
Craig R. McClanahan
d3b8b85e48 Make SimpleLog check for its "simplelog.properties" resource in the thread 
context class loader, if present, while using the same trick LogFactory
does to protect JDK 1.1 compatibility.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138895 13f79535-47bb-0310-9956-ffa450edef68
 2002-06-15 20:54:48 +00:00
Craig R. McClanahan
08ee4c68c3 Cosmetic changes in comments, to keep the JDK 1.4 standard JavaDoc 
doclet from whining.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138894 13f79535-47bb-0310-9956-ffa450edef68
 2002-06-15 18:13:02 +00:00
Richard A. Sitze
6b15ddfe75 Resolve NullPointerExceptions 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138893 13f79535-47bb-0310-9956-ffa450edef68
 2002-06-11 22:47:21 +00:00
Richard A. Sitze
2a26463d60 Correct new method name 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138892 13f79535-47bb-0310-9956-ffa450edef68
 2002-06-11 22:35:33 +00:00
Richard A. Sitze
329f05ee4f Resolve NullPointerExceptions, remove redundant checks, minor refactoring to facilitate readability. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138891 13f79535-47bb-0310-9956-ffa450edef68
 2002-06-11 22:34:32 +00:00
Richard A. Sitze
470f3338d0 Resolve NullPointerExceptions, remove redundant checks, minor refactoring to facilitate readability. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138890 13f79535-47bb-0310-9956-ffa450edef68
 2002-06-11 22:29:14 +00:00
Costin Manolache
b2038dcc68 Make sure we are initialized for all constructors. Change the name of the 
default appender.

I still have some problems with log4j's JMX if I construct the logger
via API ( i.e. no log4j.properties ) - but that shouldn't affect too
many people, so I'll leave it.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138888 13f79535-47bb-0310-9956-ffa450edef68
 2002-06-07 00:22:54 +00:00
Costin Manolache
d7208355d3 Few fixes: 
- if no log4j.properties is found, we'll construct a 'sane' config ( to be
consistent with the other loggers ). The appender must have a name ( otherwise
the JMX stuff in log4j will complain )

- fix the class name for the log4j factory


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138886 13f79535-47bb-0310-9956-ffa450edef68
 2002-06-06 22:09:09 +00:00
Costin Manolache
97e35d1253 Added a class-path directive, that avoids the need to set CLASSPATH manually. 
( we should probably add the other loggers - only what is found is used,
it doesn't hurt anyone ).

Even if most containers will automatically add whatever is in lib, if you
use it in command line things are more difficult.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138885 13f79535-47bb-0310-9956-ffa450edef68
 2002-05-09 22:01:25 +00:00
Costin Manolache
b75a58b4af Few small (?) fixes: 
- for JDK1.4, include the correct class/method. This uses a hack to
extract the information from the stack trace - probably slow, but
it's better to get the correct information.

- for log4j, check if log4j is initialized ( by checking if any appenders
are present ). Set a default configuration if it is not initialized.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138884 13f79535-47bb-0310-9956-ffa450edef68
 2002-05-06 21:32:37 +00:00
Scott Sanders
739f6cecfe Modified to use the same classloader when defaulting 
to the default log factory


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138883 13f79535-47bb-0310-9956-ffa450edef68
 2002-05-04 19:50:29 +00:00
Craig R. McClanahan
025dc566b9 The Jdk14Logger wrapper should not be modifying the configuration of the 
underlying logger.

Submitted by:  Christophe Felix-Henry <cfelixhenry at scort.com>


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138882 13f79535-47bb-0310-9956-ffa450edef68
 2002-04-29 16:48:09 +00:00
Craig R. McClanahan
6bafa3f510 Modify the logger discovery contract to perform the complete set of checks 
even in environments (such as an Applet) where System.getProperty() throws
a security exception.  Previously, this was causing the checks for Log4J or
JDK 1.4 logging to be skipped.

PR:  Bugzilla #7468
Reported By:  Tim Vernum (tpv at spamcop.net)


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138881 13f79535-47bb-0310-9956-ffa450edef68
 2002-03-31 00:31:49 +00:00
Craig R. McClanahan
4487056de8 Remove forgotten debugging statement. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138880 13f79535-47bb-0310-9956-ffa450edef68
 2002-03-15 22:57:36 +00:00
Robert Burrell Donkin
324af077b3 Corrected missing end tag in java doc comments 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@138879 13f79535-47bb-0310-9956-ffa450edef68
 2002-03-11 22:40:19 +00:00