1
0
Commit Graph

729 Commits

Author SHA1 Message Date
Robert Burrell Donkin
c68be0fed3 Added guards around diagnostic logging. Is unlikely to have much effect on real life performance but is good practice and should stop questions.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377229 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 20:01:28 +00:00
Robert Burrell Donkin
7c807d78c7 Added diagnostic logging for security exceptions.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377202 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:39:40 +00:00
Robert Burrell Donkin
5d1fcf3662 Added quotes to diagnostic messages.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377201 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:34:53 +00:00
Robert Burrell Donkin
a62f12925f Fix typo, changed some colons to dashes (colons overused) and added some quotes.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377200 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:31:21 +00:00
Robert Burrell Donkin
4b315332db Print classloader details when the class loaded is incompatible. Added comment suggesting fix.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377199 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:28:32 +00:00
Robert Burrell Donkin
b765938bfe Added single quote around class name and corrected capitalization.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377198 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:20:29 +00:00
Robert Burrell Donkin
6f52ab12b1 Prefixed environmental diagnostic content with [ENV].
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377197 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:18:07 +00:00
Robert Burrell Donkin
5d48ac1008 Added instance OID to prefix for LogFactoryImpl. This allows cross-referencing to details such as the TCCL managed by the instance.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377196 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:09:43 +00:00
Robert Burrell Donkin
b86aad5988 Log hierarchy for TCCL.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377195 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 16:00:22 +00:00
Robert Burrell Donkin
42266eebbf Prefixed all diagnostic content during LogFactory implementation discovery by [LOOKUP]. This should make it easier for users to link the content together when they analyse the logs.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377194 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 15:41:38 +00:00
Robert Burrell Donkin
22aaea10a4 Factored hierarchical section of environmental diagnostic logging into separate method so that it can be reused.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377192 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 15:36:29 +00:00
Robert Burrell Donkin
28cbe64b0e Sun classloaders typically have very bad toString methods. Others (for example, IDM classloaders) output useful information. Added toString call which may be very useful in the latter case.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377189 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 15:07:32 +00:00
Robert Burrell Donkin
cc01f0f023 A lot of colons are used in the diagnostic logs. Changed to use [INFO] in this case since it fits better with usage elsewhere.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377187 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 14:55:14 +00:00
Robert Burrell Donkin
d2fcbd4b36 Changed private method name to better reflect current purpose.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377186 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 14:53:40 +00:00
Robert Burrell Donkin
d1dcf8a3e2 Added single quotes to diagnostic class names to improve readability.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377185 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 14:51:36 +00:00
Robert Burrell Donkin
621dd503a6 Consistent prefixes for diagnostics messages. Reduced length (to make more readable when used in container) by stripping package. Changed LogFactory to use OID for classloader.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377184 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 14:46:03 +00:00
Robert Burrell Donkin
51a1fcbddd Added content prefixes for LogFactory bootstrap diagnostics. Also added message to indicate when the bootstrap has been completed.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377152 13f79535-47bb-0310-9956-ffa450edef68
2006-02-12 11:12:11 +00:00
Robert Burrell Donkin
796501a41d Java documentation improvements: added notes about the value of the constants describes where they might be useful to a user.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377058 13f79535-47bb-0310-9956-ffa450edef68
2006-02-11 21:20:55 +00:00
Robert Burrell Donkin
2a67af6bfc Update to number RC4
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377017 13f79535-47bb-0310-9956-ffa450edef68
2006-02-11 19:14:22 +00:00
Robert Burrell Donkin
df4e6edb4a Improved message issued when user specified log class cannot be loaded: when the name is close to that of one of the standard implementations, a hint is provided.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@376454 13f79535-47bb-0310-9956-ffa450edef68
2006-02-09 22:16:12 +00:00
Simon Kitching
6a015667eb Fix problem where getResources method causes NoSuchMethodError on 1.1 JVMs,
due to lack of ClassLoader.getResources method. See bugzilla #37484.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@375866 13f79535-47bb-0310-9956-ffa450edef68
2006-02-08 05:46:03 +00:00
Robert Burrell Donkin
e79f98f343 Added release candidate version.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@375708 13f79535-47bb-0310-9956-ffa450edef68
2006-02-07 21:12:28 +00:00
Robert Burrell Donkin
f674577eb8 Added catch and retry using class classloader block. This should hopefully address the cases where the TCCL is not set reasonably.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@375696 13f79535-47bb-0310-9956-ffa450edef68
2006-02-07 20:48:02 +00:00
Robert Burrell Donkin
41863c3cc8 Please check this long addition carefully. Hopefully the in-code comments should describe the reasons for this change but I'll outline them here as well. ClassLoader#getParent can return null to indicate the bootstrap classloader. Sun's implementations do not but this behaviour might be encountered in other JVMs. I haven't been able to test this patch so please check this very carefully.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@375631 13f79535-47bb-0310-9956-ffa450edef68
2006-02-07 15:38:22 +00:00
Robert Burrell Donkin
a48c939fe4 Improved diagnostics
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@374538 13f79535-47bb-0310-9956-ffa450edef68
2006-02-02 22:56:55 +00:00
Robert Burrell Donkin
230500ea51 Improved exception message. This should allow users who add whitespace to easily see that they've made a mistake.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@372295 13f79535-47bb-0310-9956-ffa450edef68
2006-01-25 19:16:03 +00:00
Simon Kitching
f8d25b3b92 Update javadoc now that WeakHashtable is part of the standard distribution.
ServletContextCleaner is only a backup for odd corner cases.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371450 13f79535-47bb-0310-9956-ffa450edef68
2006-01-23 03:18:47 +00:00
Simon Kitching
a341992b05 Fix javadoc to remove references to "optional" jar, as this class is
now in the main distribution.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371448 13f79535-47bb-0310-9956-ffa450edef68
2006-01-23 03:10:45 +00:00
Robert Burrell Donkin
7e29578fca Added attribute recommended by release best practices document.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371409 13f79535-47bb-0310-9956-ffa450edef68
2006-01-22 22:38:23 +00:00
Robert Burrell Donkin
506707c7e2 Added @since tags as recommended in the release best practices document.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371403 13f79535-47bb-0310-9956-ffa450edef68
2006-01-22 22:07:31 +00:00
Dennis Lundberg
80fba3b101 Eliminate javadoc warnings and errors. Issue #38344. Thanks to Rahul Akolkar.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371108 13f79535-47bb-0310-9956-ffa450edef68
2006-01-21 19:39:46 +00:00
Robert Burrell Donkin
df40010452 Added a note about the reason for this change. Might be useful to those that come after us...
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@371089 13f79535-47bb-0310-9956-ffa450edef68
2006-01-21 17:19:05 +00:00
Dennis Lundberg
bc48278ce3 Remove whitespace before package declaration.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370915 13f79535-47bb-0310-9956-ffa450edef68
2006-01-20 22:36:31 +00:00
Simon Kitching
c86b4fc224 Added Specification-Title as suggested by Joerg Schaible.
Added Implementation-Vendor-Id as recommended at http://java.sun.com/j2se/1.5.0/docs/guide/extensions/versioning.html


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370773 13f79535-47bb-0310-9956-ffa450edef68
2006-01-20 10:16:55 +00:00
Simon Kitching
9cf2bf6e85 Fix comment only - HashMap *is* in java1.2
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370753 13f79535-47bb-0310-9956-ffa450edef68
2006-01-20 07:46:30 +00:00
Simon Kitching
8ba8c0f9ef Fix for java1.2: in that version, Boolean.valueOf(str) returns a new instance
each time, not one of Boolean.TRUE or Boolean.FALSE!


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370752 13f79535-47bb-0310-9956-ffa450edef68
2006-01-20 07:45:22 +00:00
Simon Kitching
ced5aa9dc7 Add unit tests for ServletContextCleaner class.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370739 13f79535-47bb-0310-9956-ffa450edef68
2006-01-20 05:54:27 +00:00
Simon Kitching
0077ddf3cd Added comments only.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370738 13f79535-47bb-0310-9956-ffa450edef68
2006-01-20 05:53:42 +00:00
Simon Kitching
fe23e42c56 Add 2-param version of newFactory method for backwards compatibility. As described in the
javadoc, it could only ever be invoked by a very weird custom subclass of LogFactory but
it was technically an incompatibility so it's now fixed.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370718 13f79535-47bb-0310-9956-ffa450edef68
2006-01-20 03:38:04 +00:00
Simon Kitching
7b26b353f7 Fixed javadoc warnings: @param did not match real param name.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370699 13f79535-47bb-0310-9956-ffa450edef68
2006-01-20 02:29:48 +00:00
Simon Kitching
468b013d05 Fixes due to renaming of Log4J12Logger back to Log4JLogger
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370673 13f79535-47bb-0310-9956-ffa450edef68
2006-01-19 23:53:55 +00:00
Simon Kitching
fc9408a84f Remove Log4J13Logger; log4j 1.3 is not yet released.
Rename Log4J12Logger back to old name of Log4JLogger.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370672 13f79535-47bb-0310-9956-ffa450edef68
2006-01-19 23:52:23 +00:00
Robert Burrell Donkin
7fd0e64429 Javadoc improvements. Contributed by Boris Unckel. Issue #38174.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370659 13f79535-47bb-0310-9956-ffa450edef68
2006-01-19 22:48:16 +00:00
Robert Burrell Donkin
209b1f0688 Javadoc improvements. Contributed by Boris Unckel. Issue #38174.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370654 13f79535-47bb-0310-9956-ffa450edef68
2006-01-19 22:31:02 +00:00
Robert Burrell Donkin
ec82b0f579 Javadoc improvements. Contributed by Boris Unckel. Issue #38174.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370652 13f79535-47bb-0310-9956-ffa450edef68
2006-01-19 22:23:48 +00:00
Robert Burrell Donkin
64a4980cc3 Javadoc improvements. Contributed by Boris Unckel. Issue #38174.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370651 13f79535-47bb-0310-9956-ffa450edef68
2006-01-19 22:12:10 +00:00
Simon Kitching
ef58065fb1 Update version to 1.1 in MANIFEST.MF
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370635 13f79535-47bb-0310-9956-ffa450edef68
2006-01-19 21:16:47 +00:00
Robert Burrell Donkin
1f391b01cf Javadoc improvements. Contributed by Boris Unckel. Issue #38174.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370633 13f79535-47bb-0310-9956-ffa450edef68
2006-01-19 20:59:36 +00:00
Robert Burrell Donkin
65b0cc351b Javadoc improvements. Contributed by Boris Unckel. Issue #38174.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370631 13f79535-47bb-0310-9956-ffa450edef68
2006-01-19 20:50:46 +00:00
Robert Burrell Donkin
82703af9c8 Javadoc improvements. Contributed by Boris Unckel. Issue #38174.
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@370618 13f79535-47bb-0310-9956-ffa450edef68
2006-01-19 20:32:32 +00:00