Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity
593 Commits 1 Branch 0 Tags
111ea9540b302d6f7ac6e0d1ba4b059d53ad6d74
Commit Graph

232 Commits

Author SHA1 Message Date
Simon Kitching
111ea9540b * Add method getSystemProperty which fetches system properties using an AccessController, 
so they are accessable by a trusted JCL lib called from untrusted code.
* Add method getContextClassLoaderInternal to fetch context classloader using an
AccessController, as the parent LogFactory class no longer exposes this (restricted)
object for any subclass to access.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@424066 13f79535-47bb-0310-9956-ffa450edef68
 2006-07-20 21:08:49 +00:00
Simon Kitching
6bad2dd657 * INCOMPATIBLE CHANGE (minor): protected method getContextClassloader no longer uses an AccessController. 
This was a (minor) security flaw. Instead, behaviour is reverted to pre-1.1 behaviour where no
AccessController is used, and a new private method getContextClassloaderInternal has been created. The
chance of breaking valid user code is extremely small here. Note that this forces subclass LogFactoryImpl
to provide its own copy of getContextClassloaderInternal, as the parent no longer exposes the (restricted)
context classloader object.
* Get system properties using an AccessController so they are accessable by a trusted JCL lib called
from untrusted code.
* Revert recent patch to run entire static initializer under an AccessController, as the chances of
creating a security flaw are too high. The specific problem this patch was intended to fix has been
addressed by fetching specific system properties via an AccessController.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@424063 13f79535-47bb-0310-9956-ffa450edef68
 2006-07-20 21:06:09 +00:00
Simon Kitching
beeeaba151 Fix LOGGING-106 where JCL wouldn't start when run under a SecurityManager that refuses access to system properties. 
Also use an AccessController so that a signed JCL will work in an unsigned app; note that there appears to be other
places where we are missing AccessControllers too.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@423654 13f79535-47bb-0310-9956-ffa450edef68
 2006-07-19 23:31:00 +00:00
Simon Kitching
75688e6a39 Remove unused variable. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@406293 13f79535-47bb-0310-9956-ffa450edef68
 2006-05-14 09:35:42 +00:00
Robert Burrell Donkin
35e8d9a94e Emphasized that DIAGNOSTICS_DEST_PROPERTY is a constant. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@399431 13f79535-47bb-0310-9956-ffa450edef68
 2006-05-03 20:58:34 +00:00
Robert Burrell Donkin
481a7fc7ca Corrected non-harmful mistake spotted by Dennis Lundberg. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@399417 13f79535-47bb-0310-9956-ffa450edef68
 2006-05-03 20:38:01 +00:00
Dennis Lundberg
04305e4cc5 Add some JavaDocs. 
Correct JavaDocs.
Replace tab-characters with spaces.

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@399225 13f79535-47bb-0310-9956-ffa450edef68
 2006-05-03 09:29:00 +00:00
Dennis Lundberg
96854d71f6 Added some JavaDocs. 
Removed a copy-pasted comment that didn't belong there.

git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@399224 13f79535-47bb-0310-9956-ffa450edef68
 2006-05-03 09:25:54 +00:00
Dennis Lundberg
5f4391761d Correct JavaDoc links (@see). 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@399221 13f79535-47bb-0310-9956-ffa450edef68
 2006-05-03 09:20:24 +00:00
Robert Burrell Donkin
f05517ec95 Need to match at least the first 5 characters. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@395346 13f79535-47bb-0310-9956-ffa450edef68
 2006-04-19 18:46:30 +00:00
Simon Kitching
ac4bd0a7cd The use of static Log objects may or may not be safe depending on how that code is 
intended to be deployed. It's therefore better for the examples to show the safest
approach (without static fields).


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@395185 13f79535-47bb-0310-9956-ffa450edef68
 2006-04-19 09:33:50 +00:00
Simon Kitching
a7349b8120 Fix problem with "suggested" alternative for invalid log adapter class. 
Always trim whitespace from user-specified log adapter class name.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@395181 13f79535-47bb-0310-9956-ffa450edef68
 2006-04-19 08:57:54 +00:00
Simon Kitching
fea8fb4449 * Log the classloader that really loaded the adapter class, rather than the one 
we called loadClass on.
* Remove some debug code accidentally committed recently.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394649 13f79535-47bb-0310-9956-ffa450edef68
 2006-04-17 09:16:28 +00:00
Simon Kitching
21d9e3c157 Fix dumb double-test. Thanks to Dennis Lundberg for pointing this out. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394560 13f79535-47bb-0310-9956-ffa450edef68
 2006-04-16 21:20:21 +00:00
Simon Kitching
1f32b55765 Improve diagnostics 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394467 13f79535-47bb-0310-9956-ffa450edef68
 2006-04-16 12:15:30 +00:00
Simon Kitching
ef627680ff Improve diagnostic output 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394466 13f79535-47bb-0310-9956-ffa450edef68
 2006-04-16 12:11:05 +00:00
Simon Kitching
76cc63f74c Improve diagnostics 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394462 13f79535-47bb-0310-9956-ffa450edef68
 2006-04-16 11:43:29 +00:00
Simon Kitching
1c67c2510f Fix bug where priority of first commons-logging.properties file found was ignored. 
Also improve diagnostics output.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394461 13f79535-47bb-0310-9956-ffa450edef68
 2006-04-16 11:36:37 +00:00
Robert Burrell Donkin
dfbafcfb30 Improved diagnostics and added more information to the message thrown when a custom LogFactory cannot be loaded due to classloader incompatibilities. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@384025 13f79535-47bb-0310-9956-ffa450edef68
 2006-03-07 21:54:57 +00:00
Simon Kitching
7870118ec9 Another minor diagnostics tweak. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381887 13f79535-47bb-0310-9956-ffa450edef68
 2006-03-01 03:15:40 +00:00
Simon Kitching
d6dfbd01eb * Fix minor syntax error in previous checkin (oops). 
* Improve error message when custom LogFactory class cannot be instantiated due
to class cast issues.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381886 13f79535-47bb-0310-9956-ffa450edef68
 2006-03-01 03:11:41 +00:00
Simon Kitching
497c9ae5f1 Add a diagnostic message, and add some comments related to issues when a 
LogFactory implementation cannot be instantiated.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381879 13f79535-47bb-0310-9956-ffa450edef68
 2006-03-01 02:49:34 +00:00
Simon Kitching
08cd79161b Trivial javadoc patch to add return type info for isXXXEnabled methods. 
Thanks to Boris Unckel for patch; see bugzilla#38783.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381838 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-28 23:57:11 +00:00
Simon Kitching
eb89dd6405 Diagnostics changes only: 
* Output correct classloader used to load LogFactory implementation
* Use word "from" instead of confusing "->"
* Other minor improvements to diagnostics messages.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381828 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-28 23:32:27 +00:00
Simon Kitching
dc5a557622 Minor diagnostics tweak: use word "from" instead of confusion "->". 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381826 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-28 23:31:20 +00:00
Simon Kitching
bdec71cc5a Minor enhancement to diagnostic message. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@381224 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-27 02:28:39 +00:00
Simon Kitching
a6d1f7c256 Removed Serializable marker interface as it is not possible to implement this 
correctly in all cases. AvalonLogger was introduced in 1.0.4, and was marked
Serializable. However serialization for this class was *completely* broken in
all cases in that release, so removing the Serializable marker is not considered
a binary-incompatible change.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@379680 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-22 04:53:08 +00:00
Robert Burrell Donkin
bf61edb4c3 Reverted 375631 (null getParent). After discussions about the relevant javadocs, it was established that the interpretation which lead to this patch is probably wrong. The original implementation supplies null to Class.forName which should create the class from the boot loader. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377868 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-14 22:38:07 +00:00
Robert Burrell Donkin
b03846809e Improved diagnostic message by adding quotes. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377237 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 20:25:13 +00:00
Robert Burrell Donkin
271a6784d2 Improved diagnostic message by adding quotes. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377235 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 20:23:13 +00:00
Robert Burrell Donkin
6b8f983f0d Improved diagnostic message. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377234 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 20:20:03 +00:00
Robert Burrell Donkin
5106722c82 Improved diagnostic message. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377232 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 20:17:33 +00:00
Robert Burrell Donkin
42488ff8df Improved diagnostic message. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377231 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 20:15:17 +00:00
Robert Burrell Donkin
c68be0fed3 Added guards around diagnostic logging. Is unlikely to have much effect on real life performance but is good practice and should stop questions. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377229 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 20:01:28 +00:00
Robert Burrell Donkin
7c807d78c7 Added diagnostic logging for security exceptions. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377202 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 16:39:40 +00:00
Robert Burrell Donkin
5d1fcf3662 Added quotes to diagnostic messages. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377201 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 16:34:53 +00:00
Robert Burrell Donkin
a62f12925f Fix typo, changed some colons to dashes (colons overused) and added some quotes. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377200 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 16:31:21 +00:00
Robert Burrell Donkin
4b315332db Print classloader details when the class loaded is incompatible. Added comment suggesting fix. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377199 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 16:28:32 +00:00
Robert Burrell Donkin
b765938bfe Added single quote around class name and corrected capitalization. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377198 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 16:20:29 +00:00
Robert Burrell Donkin
6f52ab12b1 Prefixed environmental diagnostic content with [ENV]. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377197 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 16:18:07 +00:00
Robert Burrell Donkin
5d48ac1008 Added instance OID to prefix for LogFactoryImpl. This allows cross-referencing to details such as the TCCL managed by the instance. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377196 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 16:09:43 +00:00
Robert Burrell Donkin
b86aad5988 Log hierarchy for TCCL. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377195 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 16:00:22 +00:00
Robert Burrell Donkin
42266eebbf Prefixed all diagnostic content during LogFactory implementation discovery by [LOOKUP]. This should make it easier for users to link the content together when they analyse the logs. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377194 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 15:41:38 +00:00
Robert Burrell Donkin
22aaea10a4 Factored hierarchical section of environmental diagnostic logging into separate method so that it can be reused. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377192 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 15:36:29 +00:00
Robert Burrell Donkin
28cbe64b0e Sun classloaders typically have very bad toString methods. Others (for example, IDM classloaders) output useful information. Added toString call which may be very useful in the latter case. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377189 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 15:07:32 +00:00
Robert Burrell Donkin
cc01f0f023 A lot of colons are used in the diagnostic logs. Changed to use [INFO] in this case since it fits better with usage elsewhere. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377187 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 14:55:14 +00:00
Robert Burrell Donkin
d2fcbd4b36 Changed private method name to better reflect current purpose. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377186 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 14:53:40 +00:00
Robert Burrell Donkin
d1dcf8a3e2 Added single quotes to diagnostic class names to improve readability. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377185 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 14:51:36 +00:00
Robert Burrell Donkin
621dd503a6 Consistent prefixes for diagnostics messages. Reduced length (to make more readable when used in container) by stripping package. Changed LogFactory to use OID for classloader. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377184 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 14:46:03 +00:00
Robert Burrell Donkin
51a1fcbddd Added content prefixes for LogFactory bootstrap diagnostics. Also added message to indicate when the bootstrap has been completed. 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377152 13f79535-47bb-0310-9956-ffa450edef68
 2006-02-12 11:12:11 +00:00