* Log the classloader that really loaded the adapter class, rather than the one

we called loadClass on.
* Remove some debug code accidentally committed recently.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@394649 13f79535-47bb-0310-9956-ffa450edef68

src/java/org/apache/commons/logging/impl/LogFactoryImpl.java

@@ -967,7 +967,10 @@ public class LogFactoryImpl extends LogFactory {
                     + objectId(currentCL));
             try {
                 if (isDiagnosticsEnabled()) {
-                    // show exactly where we are loading this class from.
+                    // Show the location of the first occurrence of the .class file
+                    // in the classpath. This is the location that ClassLoader.loadClass
+                    // will load the class from -- unless the classloader is doing
+                    // something weird. 
                     URL url;
                     String resourceName = logAdapterClassName.replace('.', '/') + ".class";
                     if (currentCL != null) {
@@ -983,18 +986,6 @@ public class LogFactoryImpl extends LogFactory {
                     }
                 }
 
-                // hack
-                {
-                    String l4jCategory = "org.apache.log4j.Category";
-                    String l4jResource = l4jCategory.replace('.', '/') + ".class";
-                    URL l4jUrl = currentCL.getResource(l4jResource);
-                    if (l4jUrl == null) {
-                        logDiagnostic("log4j not found:" + l4jResource);
-                    } else {
-                        logDiagnostic("log4j found:" + l4jUrl);
-                    }
-                }
-
                 Class c = null;
                 try {
                     c = Class.forName(logAdapterClassName, true, currentCL);
@@ -1030,6 +1021,7 @@ public class LogFactoryImpl extends LogFactory {
                         break;
                     }
                 }
+                
                 constructor = c.getConstructor(logConstructorSignature);
                 Object o = constructor.newInstance(params);
 
@@ -1043,7 +1035,6 @@ public class LogFactoryImpl extends LogFactory {
                     break;
                 }
                 
-                
                 // Oops, we have a potential problem here. An adapter class
                 // has been found and its underlying lib is present too, but
                 // there are multiple Log interface classes available making it
@@ -1127,7 +1118,7 @@ public class LogFactoryImpl extends LogFactory {
             
             logDiagnostic(
                 "Log adapter '" + logAdapterClassName 
-                + "' from classloader " + objectId(currentCL)
+                + "' from classloader " + objectId(logAdapterClass.getClassLoader())
                 + " has been selected for use.");
         }