Prepare for the next release candidate

CONTRIBUTING.md

@@ -41,9 +41,8 @@
 Contributing to Apache Commons Logging
 ======================
 
-You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to
+Have you found a bug or have an idea for a cool new feature? Contributing code is a great way to give something back to the open-source community.
-the open source community. Before you dig right into the code there are a few guidelines that we need contributors to
+Before you dig right into the code, we need contributors to follow a few guidelines to have a chance of keeping on top of things.
-follow so that we can have a chance of keeping on top of things.
 
 Getting Started
 ---------------
@@ -62,7 +61,7 @@ Making Changes
 
 + Create a _topic branch_ for your isolated work.
   * Usually you should base your branch on the `master` branch.
-  * A good topic branch name can be the JIRA bug id plus a keyword, e.g. `LOGGING-123-InputStream`.
+  * A good topic branch name can be the JIRA bug ID plus a keyword, e.g. `LOGGING-123-InputStream`.
   * If you have submitted multiple JIRA issues, try to maintain separate branches and pull requests.
 + Make commits of logical units.
   * Make sure your commit messages are meaningful and in the proper format. Your commit message should contain the key of the JIRA issue.
@@ -72,7 +71,7 @@ Making Changes
   + Create minimal diffs - disable _On Save_ actions like _Reformat Source Code_ or _Organize Imports_. If you feel the source code should be reformatted create a separate PR for this change first.
   + Check for unnecessary whitespace with `git diff` -- check before committing.
 + Make sure you have added the necessary tests for your changes, typically in `src/test/java`.
-+ Run all the tests with `mvn clean verify` to assure nothing else was accidentally broken.
++ Run all the tests with `mvn clean verify` to ensure nothing else was accidentally broken.
 
 Making Trivial Changes
 ----------------------

README.md

@@ -45,7 +45,7 @@ Apache Commons Logging
 
 [![Java CI](https://github.com/apache/commons-logging/actions/workflows/maven.yml/badge.svg)](https://github.com/apache/commons-logging/actions/workflows/maven.yml)
 [![Maven Central](https://maven-badges.herokuapp.com/maven-central/commons-logging/commons-logging/badge.svg?gav=true)](https://maven-badges.herokuapp.com/maven-central/commons-logging/commons-logging/?gav=true)
-[![Javadocs](https://javadoc.io/badge/commons-logging/commons-logging/1.3.3.svg)](https://javadoc.io/doc/commons-logging/commons-logging/1.3.3)
+[![Javadocs](https://javadoc.io/badge/commons-logging/commons-logging/1.3.4.svg)](https://javadoc.io/doc/commons-logging/commons-logging/1.3.4)
 [![CodeQL](https://github.com/apache/commons-logging/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/apache/commons-logging/actions/workflows/codeql-analysis.yml)
 [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/apache/commons-logging/badge)](https://api.securityscorecards.dev/projects/github.com/apache/commons-logging)
 
@@ -63,13 +63,13 @@ Getting the latest release
 --------------------------
 You can download source and binaries from our [download page](https://commons.apache.org/proper/commons-logging/download_logging.cgi).
 
-Alternatively, you can pull it from  the central Maven repositories:
+Alternatively, you can pull it from the central Maven repositories:
 
 ```xml
 <dependency>
   <groupId>commons-logging</groupId>
   <artifactId>commons-logging</artifactId>
-  <version>1.3.3</version>
+  <version>1.3.4</version>
 </dependency>
 ```
 

RELEASE-NOTES.txt

@@ -1,3 +1,40 @@
+Apache Commons Logging 1.3.4 Release Notes
+------------------------------------------
+
+The Apache Commons Logging team is pleased to announce the release of Apache Commons Logging 1.3.4.
+
+Apache Commons Logging is a thin adapter allowing configurable bridging to other,
+well-known logging systems.
+
+This is a feature and maintenance release. Java 8 or later is required.
+
+Changes in this version
+-----------------------
+
+
+Fixed Bugs
+----------
+
+* LOGGING-192:  Fix factory loading from context class loader #280, #281. Thanks to Björn Kautler, Piotr Karwasz.
+
+Changes
+-------
+
+*               Bump org.apache.commons:commons-parent from 71 to 72. Thanks to Gary Gregory.
+*               Bump org.slf4j:slf4j-api from 2.0.13 to 2.0.16 #276, #282. Thanks to Gary Gregory, Dependabot.
+
+
+Historical list of changes: https://commons.apache.org/proper/commons-logging/changes-report.html
+
+Download it from https://commons.apache.org/proper/commons-logging/download_logging.cgi
+
+For complete information on Apache Commons Logging, including instructions on how to submit bug reports,
+patches, or suggestions for improvement, see the Apache Commons Logging website:
+
+https://commons.apache.org/proper/commons-logging/
+
+-----------------------------------------------------------------------------
+
 Apache Commons Logging 1.3.3 Release Notes
 ------------------------------------------
 

src/changes/changes.xml

@@ -43,7 +43,7 @@ The <action> type attribute can be add,update,fix,remove.
     <title>Release Notes</title>
   </properties>
   <body>
-    <release version="1.3.4" date="YYYY-MM-DD" description="This is a feature and maintenance release. Java 8 or later is required.">
+    <release version="1.3.4" date="2024-08-16" description="This is a feature and maintenance release. Java 8 or later is required.">
       <!-- FIX -->
       <action dev="pkarwasz" issue="LOGGING-192" type="fix" due-to="Björn Kautler, Piotr Karwasz">Fix factory loading from context class loader #280, #281.</action>
       <!-- ADD -->

src/site/xdoc/download_logging.xml

@@ -113,32 +113,32 @@ limitations under the License.
       </p>
     </subsection>
     </section>
-    <section name="Apache Commons Logging 1.3.3 ">
+    <section name="Apache Commons Logging 1.3.4 ">
       <subsection name="Binaries">
         <table>
           <tr>
-              <td><a href="[preferred]/commons/logging/binaries/commons-logging-1.3.3-bin.tar.gz">commons-logging-1.3.3-bin.tar.gz</a></td>
+              <td><a href="[preferred]/commons/logging/binaries/commons-logging-1.3.4-bin.tar.gz">commons-logging-1.3.4-bin.tar.gz</a></td>
-              <td><a href="https://downloads.apache.org/commons/logging/binaries/commons-logging-1.3.3-bin.tar.gz.sha512">sha512</a></td>
+              <td><a href="https://downloads.apache.org/commons/logging/binaries/commons-logging-1.3.4-bin.tar.gz.sha512">sha512</a></td>
-              <td><a href="https://downloads.apache.org/commons/logging/binaries/commons-logging-1.3.3-bin.tar.gz.asc">pgp</a></td>
+              <td><a href="https://downloads.apache.org/commons/logging/binaries/commons-logging-1.3.4-bin.tar.gz.asc">pgp</a></td>
           </tr>
           <tr>
-              <td><a href="[preferred]/commons/logging/binaries/commons-logging-1.3.3-bin.zip">commons-logging-1.3.3-bin.zip</a></td>
+              <td><a href="[preferred]/commons/logging/binaries/commons-logging-1.3.4-bin.zip">commons-logging-1.3.4-bin.zip</a></td>
-              <td><a href="https://downloads.apache.org/commons/logging/binaries/commons-logging-1.3.3-bin.zip.sha512">sha512</a></td>
+              <td><a href="https://downloads.apache.org/commons/logging/binaries/commons-logging-1.3.4-bin.zip.sha512">sha512</a></td>
-              <td><a href="https://downloads.apache.org/commons/logging/binaries/commons-logging-1.3.3-bin.zip.asc">pgp</a></td>
+              <td><a href="https://downloads.apache.org/commons/logging/binaries/commons-logging-1.3.4-bin.zip.asc">pgp</a></td>
           </tr>
         </table>
       </subsection>
       <subsection name="Source">
         <table>
           <tr>
-              <td><a href="[preferred]/commons/logging/source/commons-logging-1.3.3-src.tar.gz">commons-logging-1.3.3-src.tar.gz</a></td>
+              <td><a href="[preferred]/commons/logging/source/commons-logging-1.3.4-src.tar.gz">commons-logging-1.3.4-src.tar.gz</a></td>
-              <td><a href="https://downloads.apache.org/commons/logging/source/commons-logging-1.3.3-src.tar.gz.sha512">sha512</a></td>
+              <td><a href="https://downloads.apache.org/commons/logging/source/commons-logging-1.3.4-src.tar.gz.sha512">sha512</a></td>
-              <td><a href="https://downloads.apache.org/commons/logging/source/commons-logging-1.3.3-src.tar.gz.asc">pgp</a></td>
+              <td><a href="https://downloads.apache.org/commons/logging/source/commons-logging-1.3.4-src.tar.gz.asc">pgp</a></td>
           </tr>
           <tr>
-              <td><a href="[preferred]/commons/logging/source/commons-logging-1.3.3-src.zip">commons-logging-1.3.3-src.zip</a></td>
+              <td><a href="[preferred]/commons/logging/source/commons-logging-1.3.4-src.zip">commons-logging-1.3.4-src.zip</a></td>
-              <td><a href="https://downloads.apache.org/commons/logging/source/commons-logging-1.3.3-src.zip.sha512">sha512</a></td>
+              <td><a href="https://downloads.apache.org/commons/logging/source/commons-logging-1.3.4-src.zip.sha512">sha512</a></td>
-              <td><a href="https://downloads.apache.org/commons/logging/source/commons-logging-1.3.3-src.zip.asc">pgp</a></td>
+              <td><a href="https://downloads.apache.org/commons/logging/source/commons-logging-1.3.4-src.zip.asc">pgp</a></td>
           </tr>
         </table>
       </subsection>