Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity

Added single quotes to diagnostic class names to improve readability.

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377185 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Robert Burrell Donkin
2006-02-12 14:51:36 +00:00
parent 621dd503a6
commit d1dcf8a3e2
1 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
View File

@@ -889,7 +889,7 @@ public class LogFactoryImpl extends LogFactory {
boolean affectState) boolean affectState)
throws LogConfigurationException { throws LogConfigurationException {
logDiagnostic("Attempting to instantiate " + logAdapterClassName); logDiagnostic("Attempting to instantiate '" + logAdapterClassName + "'");
Object[] params = { logCategory }; Object[] params = { logCategory };
Log logAdapter = null; Log logAdapter = null;
@@ -907,9 +907,9 @@ public class LogFactoryImpl extends LogFactory {
// Loop through the classloader hierarchy trying to find // Loop through the classloader hierarchy trying to find
// a viable classloader. // a viable classloader.
logDiagnostic( logDiagnostic(
"Trying to load " "Trying to load '"
+ logAdapterClassName + logAdapterClassName
+ " from classloader " + "' from classloader "
+ objectId(currentCL)); + objectId(currentCL));
try { try {
Class c = null; Class c = null;
@@ -921,9 +921,9 @@ public class LogFactoryImpl extends LogFactory {
// trying higher up in the hierarchy in this case.. // trying higher up in the hierarchy in this case..
String msg = "" + originalClassNotFoundException.getMessage(); String msg = "" + originalClassNotFoundException.getMessage();
logDiagnostic( logDiagnostic(
"The log adapter " "The log adapter '"
+ logAdapterClassName + logAdapterClassName
+ " is not available via classloader " + "' is not available via classloader "
+ objectId(currentCL) + objectId(currentCL)
+ ": " + ": "
+ msg.trim()); + msg.trim());
@@ -940,9 +940,9 @@ public class LogFactoryImpl extends LogFactory {
// no point continuing: this adapter isn't available // no point continuing: this adapter isn't available
msg = "" + secondaryClassNotFoundException.getMessage(); msg = "" + secondaryClassNotFoundException.getMessage();
logDiagnostic( logDiagnostic(
"The log adapter " "The log adapter '"
+ logAdapterClassName + logAdapterClassName
+ " is not available via the LogFactoryImpl class classloader: " + "' is not available via the LogFactoryImpl class classloader: "
+ msg.trim()); + msg.trim());
break; break;
} }
@@ -980,9 +980,9 @@ public class LogFactoryImpl extends LogFactory {
// in the hierarchy in this case.. // in the hierarchy in this case..
String msg = "" + e.getMessage(); String msg = "" + e.getMessage();
logDiagnostic( logDiagnostic(
"The log adapter " "The log adapter '"
+ logAdapterClassName + logAdapterClassName
+ " is missing dependencies when loaded via classloader " + "' is missing dependencies when loaded via classloader "
+ objectId(currentCL) + objectId(currentCL)
+ ": " + ": "
+ msg.trim()); + msg.trim());
@@ -996,9 +996,9 @@ public class LogFactoryImpl extends LogFactory {
// library could not be found. // library could not be found.
String msg = "" + e.getMessage(); String msg = "" + e.getMessage();
logDiagnostic( logDiagnostic(
"The log adapter " "The log adapter '"
+ logAdapterClassName + logAdapterClassName
+ " is unable to initialize itself when loaded via classloader " + "' is unable to initialize itself when loaded via classloader "
+ objectId(currentCL) + objectId(currentCL)
+ ": " + ": "
+ msg.trim()); + msg.trim());
@@ -1090,20 +1090,20 @@ public class LogFactoryImpl extends LogFactory {
try { try {
this.logMethod = logAdapterClass.getMethod("setLogFactory", this.logMethod = logAdapterClass.getMethod("setLogFactory",
logMethodSignature); logMethodSignature);
logDiagnostic("Found method setLogFactory(LogFactory) in " logDiagnostic("Found method setLogFactory(LogFactory) in '"
+ logAdapterClassName); + logAdapterClassName + "'");
} catch (Throwable t) { } catch (Throwable t) {
this.logMethod = null; this.logMethod = null;
logDiagnostic( logDiagnostic(
"info:" + logAdapterClassName "info: '" + logAdapterClassName
+ " from classloader " + objectId(currentCL) + "' from classloader " + objectId(currentCL)
+ " does not declare optional method " + " does not declare optional method "
+ "setLogFactory(LogFactory)"); + "setLogFactory(LogFactory)");
} }
logDiagnostic( logDiagnostic(
"Log adapter " + logAdapterClassName "Log adapter '" + logAdapterClassName
+ " from classloader " + objectId(currentCL) + "' from classloader " + objectId(currentCL)
+ " has been selected for use."); + " has been selected for use.");
} }
@@ -1248,8 +1248,8 @@ public class LogFactoryImpl extends LogFactory {
ClassLoader classLoader, ClassLoader classLoader,
Throwable discoveryFlaw) { Throwable discoveryFlaw) {
logDiagnostic("Could not instantiate Log " logDiagnostic("Could not instantiate Log '"
+ logAdapterClassName + " -- " + logAdapterClassName + "' -- "
+ discoveryFlaw.getLocalizedMessage()); + discoveryFlaw.getLocalizedMessage());
if (!allowFlawedDiscovery) { if (!allowFlawedDiscovery) {