Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity

Tweaked test to improve portability across JVMs. (Added sorting of resource to ensure known order.)

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209642 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Robert Burrell Donkin
2005-07-07 20:16:25 +00:00
parent dfc008fc82
commit d163dc0a8f
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/test/org/apache/commons/logging/pathable/ParentFirstTestCase.java
View File

@@ -16,6 +16,7 @@
package org.apache.commons.logging.pathable; package org.apache.commons.logging.pathable;
import java.net.URL; import java.net.URL;
import java.util.Arrays;
import java.util.Enumeration; import java.util.Enumeration;
import java.util.ArrayList; import java.util.ArrayList;
import java.net.URLClassLoader; import java.net.URLClassLoader;
@@ -231,10 +232,17 @@ public class ParentFirstTestCase extends TestCase {
resources = childLoader.getResources("org/apache/commons/logging/impl/Log4J12Logger.class"); resources = childLoader.getResources("org/apache/commons/logging/impl/Log4J12Logger.class");
urls = toURLArray(resources); urls = toURLArray(resources);
assertEquals("Unexpected number of Log4J12Logger.class resources found", 2, urls.length); assertEquals("Unexpected number of Log4J12Logger.class resources found", 2, urls.length);
// There is no gaurantee about the ordering of results returned from getResources
// To make this test portable across JVMs, sort the string to give them a known order
String[] urlsToStrings = new String[2];
urlsToStrings[0] = urls[0].toString();
urlsToStrings[1] = urls[1].toString();
Arrays.sort(urlsToStrings);
assertTrue("Incorrect source for Log4J12Logger class", assertTrue("Incorrect source for Log4J12Logger class",
urls[0].toString().indexOf("/commons-logging-1.") > 0); urlsToStrings[0].indexOf("/commons-logging-1.") > 0);
assertTrue("Incorrect source for Log4J12Logger class", assertTrue("Incorrect source for Log4J12Logger class",
urls[1].toString().indexOf("/commons-logging-adapters-1.") > 0); urlsToStrings[1].indexOf("/commons-logging-adapters-1.") > 0);
} }