From d1123e424d3a589d5fd5f911081b8218f5ff4833 Mon Sep 17 00:00:00 2001
From: Thomas Neidhart <tn@apache.org>
Date: Sat, 12 Jan 2013 16:24:19 +0000
Subject: [PATCH] Add serialVersionUID where needed, some javadoc fixes.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/logging/trunk@1432465 13f79535-47bb-0310-9956-ffa450edef68
---
 .../commons/logging/LogConfigurationException.java |  3 +++
 src/java/org/apache/commons/logging/LogSource.java | 14 +++++++-------
 .../logging/impl/Jdk13LumberjackLogger.java        |  3 +++
 .../apache/commons/logging/impl/Jdk14Logger.java   |  3 +++
 .../apache/commons/logging/impl/Log4JLogger.java   |  3 +++
 .../apache/commons/logging/impl/LogKitLogger.java  |  3 +++
 .../org/apache/commons/logging/impl/NoOpLog.java   |  3 +++
 .../org/apache/commons/logging/impl/SimpleLog.java |  3 +++
 .../apache/commons/logging/impl/WeakHashtable.java |  3 +++
 9 files changed, 31 insertions(+), 7 deletions(-)

diff --git a/src/java/org/apache/commons/logging/LogConfigurationException.java b/src/java/org/apache/commons/logging/LogConfigurationException.java
index 61ae3f3..d841716 100644
--- a/src/java/org/apache/commons/logging/LogConfigurationException.java
+++ b/src/java/org/apache/commons/logging/LogConfigurationException.java
@@ -27,6 +27,9 @@ package org.apache.commons.logging;
  */
 public class LogConfigurationException extends RuntimeException {
 
+    /** Serializable version identifier. */
+    private static final long serialVersionUID = 8486587136871052495L;
+
     /**
      * Construct a new exception with <code>null</code> as its detail message.
      */
diff --git a/src/java/org/apache/commons/logging/LogSource.java b/src/java/org/apache/commons/logging/LogSource.java
index 5d4681f..f201fac 100644
--- a/src/java/org/apache/commons/logging/LogSource.java
+++ b/src/java/org/apache/commons/logging/LogSource.java
@@ -23,12 +23,12 @@ import java.util.Hashtable;
 import org.apache.commons.logging.impl.NoOpLog;
 
 /**
- * <p>Factory for creating {@link Log} instances.  Applications should call
+ * Factory for creating {@link Log} instances.  Applications should call
  * the <code>makeNewLogInstance()</code> method to instantiate new instances
- * of the configured {@link Log} implementation class.</p>
- *
- * <p>By default, calling <code>getInstance()</code> will use the following
- * algorithm:</p>
+ * of the configured {@link Log} implementation class.
+ * <p>
+ * By default, calling <code>getInstance()</code> will use the following
+ * algorithm:
  * <ul>
  * <li>If Log4J is available, return an instance of
  *     <code>org.apache.commons.logging.impl.Log4JLogger</code>.</li>
@@ -37,8 +37,8 @@ import org.apache.commons.logging.impl.NoOpLog;
  * <li>Otherwise, return an instance of
  *     <code>org.apache.commons.logging.impl.NoOpLog</code>.</li>
  * </ul>
- *
- * <p>You can change the default behavior in one of two ways:</p>
+ * <p>
+ * You can change the default behavior in one of two ways:
  * <ul>
  * <li>On the startup command line, set the system property
  *     <code>org.apache.commons.logging.log</code> to the name of the
diff --git a/src/java/org/apache/commons/logging/impl/Jdk13LumberjackLogger.java b/src/java/org/apache/commons/logging/impl/Jdk13LumberjackLogger.java
index d6d0c9c..4ea65e8 100644
--- a/src/java/org/apache/commons/logging/impl/Jdk13LumberjackLogger.java
+++ b/src/java/org/apache/commons/logging/impl/Jdk13LumberjackLogger.java
@@ -41,6 +41,9 @@ import org.apache.commons.logging.Log;
  */
 public class Jdk13LumberjackLogger implements Log, Serializable {
 
+    /** Serializable version identifier. */
+    private static final long serialVersionUID = -8649807923527610591L;
+
     // ----------------------------------------------------- Instance Variables
 
     /**
diff --git a/src/java/org/apache/commons/logging/impl/Jdk14Logger.java b/src/java/org/apache/commons/logging/impl/Jdk14Logger.java
index edc6096..0a5c3c2 100644
--- a/src/java/org/apache/commons/logging/impl/Jdk14Logger.java
+++ b/src/java/org/apache/commons/logging/impl/Jdk14Logger.java
@@ -35,6 +35,9 @@ import org.apache.commons.logging.Log;
  */
 public class Jdk14Logger implements Log, Serializable {
 
+    /** Serializable version identifier. */
+    private static final long serialVersionUID = 4784713551416303804L;
+
     /**
      * This member variable simply ensures that any attempt to initialise
      * this class in a pre-1.4 JVM will result in an ExceptionInInitializerError.
diff --git a/src/java/org/apache/commons/logging/impl/Log4JLogger.java b/src/java/org/apache/commons/logging/impl/Log4JLogger.java
index b50f929..3f79d31 100644
--- a/src/java/org/apache/commons/logging/impl/Log4JLogger.java
+++ b/src/java/org/apache/commons/logging/impl/Log4JLogger.java
@@ -47,6 +47,9 @@ import org.apache.log4j.Level;
  */
 public class Log4JLogger implements Log, Serializable {
 
+    /** Serializable version identifier. */
+    private static final long serialVersionUID = 5160705895411730424L;
+
     // ------------------------------------------------------------- Attributes
 
     /** The fully qualified name of the Log4JLogger class. */
diff --git a/src/java/org/apache/commons/logging/impl/LogKitLogger.java b/src/java/org/apache/commons/logging/impl/LogKitLogger.java
index ecf4e89..5c35ac7 100644
--- a/src/java/org/apache/commons/logging/impl/LogKitLogger.java
+++ b/src/java/org/apache/commons/logging/impl/LogKitLogger.java
@@ -37,6 +37,9 @@ import org.apache.commons.logging.Log;
  */
 public class LogKitLogger implements Log, Serializable {
 
+    /** Serializable version identifier. */
+    private static final long serialVersionUID = 3768538055836059519L;
+
     // ------------------------------------------------------------- Attributes
 
     /** Logging goes to this <code>LogKit</code> logger */
diff --git a/src/java/org/apache/commons/logging/impl/NoOpLog.java b/src/java/org/apache/commons/logging/impl/NoOpLog.java
index 32afc61..a85e341 100644
--- a/src/java/org/apache/commons/logging/impl/NoOpLog.java
+++ b/src/java/org/apache/commons/logging/impl/NoOpLog.java
@@ -30,6 +30,9 @@ import org.apache.commons.logging.Log;
  */
 public class NoOpLog implements Log, Serializable {
 
+    /** Serializable version identifier. */
+    private static final long serialVersionUID = 561423906191706148L;
+
     /** Convenience constructor */
     public NoOpLog() { }
     /** Base constructor */
diff --git a/src/java/org/apache/commons/logging/impl/SimpleLog.java b/src/java/org/apache/commons/logging/impl/SimpleLog.java
index cdb587a..c2fd400 100644
--- a/src/java/org/apache/commons/logging/impl/SimpleLog.java
+++ b/src/java/org/apache/commons/logging/impl/SimpleLog.java
@@ -74,6 +74,9 @@ import org.apache.commons.logging.LogConfigurationException;
  */
 public class SimpleLog implements Log, Serializable {
 
+    /** Serializable version identifier. */
+    private static final long serialVersionUID = 136942970684951178L;
+
     // ------------------------------------------------------- Class Attributes
 
     /** All system properties used by <code>SimpleLog</code> start with this */
diff --git a/src/java/org/apache/commons/logging/impl/WeakHashtable.java b/src/java/org/apache/commons/logging/impl/WeakHashtable.java
index 2bc0a41..9aee8b8 100644
--- a/src/java/org/apache/commons/logging/impl/WeakHashtable.java
+++ b/src/java/org/apache/commons/logging/impl/WeakHashtable.java
@@ -117,6 +117,9 @@ import java.util.Set;
  */
 public final class WeakHashtable extends Hashtable {
 
+    /** Serializable version identifier. */
+    private static final long serialVersionUID = -1546036869799732453L;
+
     /** 
      * The maximum number of times put() or remove() can be called before
      * the map will be purged of all cleared entries.