Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity

Use for-each. Use final. Remove redundant modifiers.

Browse Source
This commit is contained in:
Gary Gregory
2020-11-21 13:39:02 -05:00
parent 66aa7aacbe
commit cd99c4164f
5 changed files with 22 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java
View File

@@ -1322,8 +1322,8 @@ public class LogFactoryImpl extends LogFactory {
boolean implementsLog = false;
final String logInterfaceName = Log.class.getName();
final Class interfaces[] = badClass.getInterfaces();
for (int i = 0; i < interfaces.length; i++) {
if (logInterfaceName.equals(interfaces[i].getName())) {
for (final Class element : interfaces) {
if (logInterfaceName.equals(element.getName())) {
implementsLog = true;
break;
}

13
src/main/java/org/apache/commons/logging/impl/WeakHashtable.java
View File

@@ -24,7 +24,6 @@ import java.util.Collection;
import java.util.Enumeration;
import java.util.HashSet;
import java.util.Hashtable;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -160,8 +159,8 @@ public final class WeakHashtable extends Hashtable {
purge();
final Set referencedEntries = super.entrySet();
final Set unreferencedEntries = new HashSet();
for (final Iterator it=referencedEntries.iterator(); it.hasNext();) {
final Map.Entry entry = (Map.Entry) it.next();
for (final Object referencedEntry : referencedEntries) {
final Map.Entry entry = (Map.Entry) referencedEntry;
final Referenced referencedKey = (Referenced) entry.getKey();
final Object key = referencedKey.getValue();
final Object value = entry.getValue();
@@ -206,8 +205,8 @@ public final class WeakHashtable extends Hashtable {
purge();
final Set referencedKeys = super.keySet();
final Set unreferencedKeys = new HashSet();
for (final Iterator it=referencedKeys.iterator(); it.hasNext();) {
final Referenced referenceKey = (Referenced) it.next();
for (final Object referencedKey : referencedKeys) {
final Referenced referenceKey = (Referenced) referencedKey;
final Object keyValue = referenceKey.getValue();
if (keyValue != null) {
unreferencedKeys.add(keyValue);
@@ -249,8 +248,8 @@ public final class WeakHashtable extends Hashtable {
public void putAll(final Map t) {
if (t != null) {
final Set entrySet = t.entrySet();
for (final Iterator it=entrySet.iterator(); it.hasNext();) {
final Map.Entry entry = (Map.Entry) it.next();
for (final Object element : entrySet) {
final Map.Entry entry = (Map.Entry) element;
put(entry.getKey(), entry.getValue());
}
}