Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity

Redundant null check: have already checked for null in enclosing conditional

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/logging/trunk@1362962 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Sebastian Bazley
2012-07-18 14:29:17 +00:00
parent 66c1dcbf47
commit cabf9b0bc0
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
View File

@@ -865,12 +865,10 @@ public class LogFactoryImpl extends LogFactory {
// Mistyping or misspelling names is a common fault. // Mistyping or misspelling names is a common fault.
// Construct a good error message, if we can // Construct a good error message, if we can
if (specifiedLogClassName != null) { informUponSimilarName(messageBuffer, specifiedLogClassName, LOGGING_IMPL_LOG4J_LOGGER);
informUponSimilarName(messageBuffer, specifiedLogClassName, LOGGING_IMPL_LOG4J_LOGGER); informUponSimilarName(messageBuffer, specifiedLogClassName, LOGGING_IMPL_JDK14_LOGGER);
informUponSimilarName(messageBuffer, specifiedLogClassName, LOGGING_IMPL_JDK14_LOGGER); informUponSimilarName(messageBuffer, specifiedLogClassName, LOGGING_IMPL_LUMBERJACK_LOGGER);
informUponSimilarName(messageBuffer, specifiedLogClassName, LOGGING_IMPL_LUMBERJACK_LOGGER); informUponSimilarName(messageBuffer, specifiedLogClassName, LOGGING_IMPL_SIMPLE_LOGGER);
informUponSimilarName(messageBuffer, specifiedLogClassName, LOGGING_IMPL_SIMPLE_LOGGER);
}
throw new LogConfigurationException(messageBuffer.toString()); throw new LogConfigurationException(messageBuffer.toString());
} }