From b9785548d6b100c6d74bc16054492815101a4d56 Mon Sep 17 00:00:00 2001
From: Gary Gregory <garydgregory@gmail.com>
Date: Sat, 25 Nov 2023 11:41:45 -0500
Subject: [PATCH] Enable PMD check in default Maven goal

---
 pmd.xml                                        | 18 +++++++++++++-----
 pom.xml                                        | 13 ++++++++++++-
 .../apache/commons/logging/impl/NoOpLog.java   |  4 ++--
 3 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/pmd.xml b/pmd.xml
index d988308..2bbe00c 100644
--- a/pmd.xml
+++ b/pmd.xml
@@ -15,11 +15,19 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
 limitations under the License.
 -->
-<ruleset name="mybraces"
-    xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
+<ruleset name="mybraces" xmlns="http://pmd.sourceforge.net/ruleset/2.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
   <description>Excludes from default PMD rules.</description>
   <rule ref="rulesets/java/unusedcode.xml">
   </rule>
-</ruleset>
\ No newline at end of file
+  <rule ref="category/java/errorprone.xml/EmptyCatchBlock">
+    <properties>
+      <property name="allowCommentedBlocks" value="true" />
+    </properties>
+  </rule>
+  <rule ref="category/java/bestpractices.xml/UnusedFormalParameter">
+    <properties>
+      <property name="violationSuppressRegex" value=".*'ignored'.*" />
+    </properties>
+  </rule>
+</ruleset>
diff --git a/pom.xml b/pom.xml
index a1d7b9f..9a66fe5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -197,7 +197,7 @@ under the License.
   <build>
     <!-- TODO spotbugs:check -->
     <!-- TODO replace clirr:check with japicmp:cmp -->
-    <defaultGoal>clean verify apache-rat:check japicmp:cmp javadoc:javadoc checkstyle:check</defaultGoal>
+    <defaultGoal>clean verify apache-rat:check japicmp:cmp javadoc:javadoc checkstyle:check pmd:check</defaultGoal>
     <plugins>
 
       <!--
@@ -534,6 +534,17 @@ under the License.
         </configuration>
       </plugin>
 
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-pmd-plugin</artifactId>
+        <configuration>
+          <targetJdk>1.8</targetJdk>
+          <rulesets>
+            <ruleset>${basedir}/pmd.xml</ruleset>
+          </rulesets>
+        </configuration>
+      </plugin>
+
     </plugins>
   </build>
 
diff --git a/src/main/java/org/apache/commons/logging/impl/NoOpLog.java b/src/main/java/org/apache/commons/logging/impl/NoOpLog.java
index 26230fd..7a50316 100644
--- a/src/main/java/org/apache/commons/logging/impl/NoOpLog.java
+++ b/src/main/java/org/apache/commons/logging/impl/NoOpLog.java
@@ -37,9 +37,9 @@ public class NoOpLog implements Log, Serializable {
     /**
      * Base constructor
      *
-     * @param name unused.
+     * @param ignoredName unused.
      */
-    public NoOpLog(final String name) {
+    public NoOpLog(final String ignoredName) {
         // no-op
     }