COMMONSSITE-30 - fix the checkstyle configuration to work for multi-module and review/update <reporting> plugin version numbers for the poms being changed.

- pom's need to use ${basedir} for configuration files as the multi-module profile is run from commons-parent, so if not specified it can't find those files
 - the checkstyle configuration file needs to use ${checkstyle.header.file} for the headerFile property and  <headerFile> element added to the plugin config in the pom.xml
 - fix m1 checkstyle config to reflect the above where appropriate (specify header file property)


git-svn-id: https://svn.apache.org/repos/asf/commons/proper/logging/trunk@659438 13f79535-47bb-0310-9956-ffa450edef68

checkstyle.xml

@@ -30,7 +30,7 @@
   <module name="TreeWalker">
     <!-- Verify that EVERY source file has the appropriate license -->
     <module name="Header">
-      <property name="headerFile" value="${basedir}/LICENSE-header.txt"/>
+      <property name="headerFile" value="${checkstyle.header.file}"/>
     </module>
 
     <module name="OperatorWrap">

license-header.txt

@@ -1,18 +1,16 @@
 /*
- * Licensed to the Apache Software Foundation (ASF) under one
+ * Licensed to the Apache Software Foundation (ASF) under one or more
- * or more contributor license agreements.  See the NOTICE file
+ * contributor license agreements.  See the NOTICE file distributed with
- * distributed with this work for additional information
+ * this work for additional information regarding copyright ownership.
- * regarding copyright ownership.  The ASF licenses this file
+ * The ASF licenses this file to You under the Apache License, Version 2.0
- * to you under the Apache License, Version 2.0 (the
+ * (the "License"); you may not use this file except in compliance with
- * "License"); you may not use this file except in compliance
+ * the License.  You may obtain a copy of the License at
- * with the License.  You may obtain a copy of the License at
+ * 
- *
+ *      http://www.apache.org/licenses/LICENSE-2.0
- *   http://www.apache.org/licenses/LICENSE-2.0
+ * 
- *
+ * Unless required by applicable law or agreed to in writing, software
- * Unless required by applicable law or agreed to in writing,
+ * distributed under the License is distributed on an "AS IS" BASIS,
- * software distributed under the License is distributed on an
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * See the License for the specific language governing permissions and
- * KIND, either express or implied.  See the License for the
+ * limitations under the License.
- * specific language governing permissions and limitations
+ */ 
- * under the License.    
- */

pom.xml

@@ -483,19 +483,20 @@ under the License.
 
   <reporting>
     <plugins>
-      <!--
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
+        <version>2.1</version>
         <configuration>
-          <configLocation>checkstyle.xml</configLocation>
+          <configLocation>${basedir}/checkstyle.xml</configLocation>
+          <enableRulesSummary>false</enableRulesSummary>
+          <headerFile>${basedir}/license-header.txt</headerFile>
         </configuration>
       </plugin>
-      -->
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>clirr-maven-plugin</artifactId>
-        <version>2.1.1</version>
+        <version>2.2</version>
       </plugin>
       <plugin>
         <groupId>org.codehaus.mojo</groupId>

project.properties

@@ -19,6 +19,7 @@ maven.repo.remote=http://repo1.maven.org/maven
 maven.changelog.factory=org.apache.maven.svnlib.SvnChangeLogFactory
 
 maven.checkstyle.properties=checkstyle.xml
+maven.checkstyle.header.file=${basedir}/license-header.txt
 
 # documentation properties
 maven.xdoc.date=left

project.xml

@@ -281,9 +281,7 @@ There is no easy way to run these under maven at the moment.
   </build>
 
   <reports>
-    <!--
     <report>maven-checkstyle-plugin</report>
-    -->
     <report>maven-javadoc-plugin</report>
     <report>maven-jdepend-plugin</report>
     <report>maven-junit-report-plugin</report>