Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity

Better error messages

Browse Source
This commit is contained in:
Gary Gregory
2023-11-20 08:56:47 -05:00
parent 2039eeba6f
commit 7e340b5d73
1 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/main/java/org/apache/commons/logging/LogFactory.java
View File

@@ -441,11 +441,11 @@ public abstract class LogFactory {
// if the user's trying to set up a custom implementation, give a clue // if the user's trying to set up a custom implementation, give a clue
if (isDiagnosticsEnabled()) { if (isDiagnosticsEnabled()) {
// use internal logging to issue the warning // use internal logging to issue the warning
logDiagnostic("[ERROR] LogFactory: Load of custom hashtable failed"); logDiagnostic("[ERROR] LogFactory: Load of custom Hashtable failed");
} else { } else {
// we *really* want this output, even if diagnostics weren't // we *really* want this output, even if diagnostics weren't
// explicitly enabled by the user. // explicitly enabled by the user.
System.err.println("[ERROR] LogFactory: Load of custom hashtable failed"); System.err.println("[ERROR] LogFactory: Load of custom Hashtable failed");
} }
} }
} }
@@ -1100,15 +1100,13 @@ public abstract class LogFactory {
logDiagnostic("[CUSTOM LOG FACTORY] was loaded by the boot classloader"); logDiagnostic("[CUSTOM LOG FACTORY] was loaded by the boot classloader");
} else { } else {
logHierarchy("[CUSTOM LOG FACTORY] ", logFactoryClassLoader); logHierarchy("[CUSTOM LOG FACTORY] ", logFactoryClassLoader);
final Class factoryFromCustomLoader final Class factoryFromCustomLoader = Class.forName("org.apache.commons.logging.LogFactory", false, logFactoryClassLoader);
= Class.forName("org.apache.commons.logging.LogFactory", false, logFactoryClassLoader);
implementsLogFactory = factoryFromCustomLoader.isAssignableFrom(logFactoryClass); implementsLogFactory = factoryFromCustomLoader.isAssignableFrom(logFactoryClass);
if (implementsLogFactory) { if (implementsLogFactory) {
logDiagnostic("[CUSTOM LOG FACTORY] " + logFactoryClass.getName() + logDiagnostic(
" implements LogFactory but was loaded by an incompatible classloader."); "[CUSTOM LOG FACTORY] " + logFactoryClass.getName() + " implements LogFactory but was loaded by an incompatible classloader.");
} else { } else {
logDiagnostic("[CUSTOM LOG FACTORY] " + logFactoryClass.getName() + logDiagnostic("[CUSTOM LOG FACTORY] " + logFactoryClass.getName() + " does not implement LogFactory.");
" does not implement LogFactory.");
} }
} }
} catch (final SecurityException e) { } catch (final SecurityException e) {
@@ -1117,8 +1115,8 @@ public abstract class LogFactory {
// This will make it very hard to diagnose issues with JCL. // This will make it very hard to diagnose issues with JCL.
// Consider running less securely whilst debugging this issue. // Consider running less securely whilst debugging this issue.
// //
logDiagnostic("[CUSTOM LOG FACTORY] SecurityException thrown whilst trying to determine whether " + logDiagnostic("[CUSTOM LOG FACTORY] SecurityException caught trying to determine whether "
"the compatibility was caused by a classloader conflict: " + e.getMessage()); + "the compatibility was caused by a class loader conflict: " + e.getMessage());
} catch (final LinkageError e) { } catch (final LinkageError e) {
// //
// This should be an unusual circumstance. // This should be an unusual circumstance.
@@ -1126,8 +1124,8 @@ public abstract class LogFactory {
// Another possibility may be an exception thrown by an initializer. // Another possibility may be an exception thrown by an initializer.
// Time for a clean rebuild? // Time for a clean rebuild?
// //
logDiagnostic("[CUSTOM LOG FACTORY] LinkageError thrown whilst trying to determine whether " + logDiagnostic("[CUSTOM LOG FACTORY] LinkageError caught trying to determine whether "
"the compatibility was caused by a classloader conflict: " + e.getMessage()); + "the compatibility was caused by a class loader conflict: " + e.getMessage());
} catch (final ClassNotFoundException e) { } catch (final ClassNotFoundException e) {
// //
// LogFactory cannot be loaded by the classloader which loaded the custom factory implementation. // LogFactory cannot be loaded by the classloader which loaded the custom factory implementation.
@@ -1136,8 +1134,8 @@ public abstract class LogFactory {
// Running with diagnostics on should give information about the classloaders used // Running with diagnostics on should give information about the classloaders used
// to load the custom factory. // to load the custom factory.
// //
logDiagnostic("[CUSTOM LOG FACTORY] LogFactory class cannot be loaded by classloader which loaded " + logDiagnostic("[CUSTOM LOG FACTORY] LogFactory class cannot be loaded by the class loader which loaded "
"the custom LogFactory implementation. Is the custom factory in the right classloader?"); + "the custom LogFactory implementation. Is the custom factory in the right class loader?");
} }
} }
return implementsLogFactory; return implementsLogFactory;