Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity

[LOGGING-135] Improved thread-safety for SimpleLog, AvalonLogger.

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/logging/trunk@1435115 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Thomas Neidhart
2013-01-18 12:40:19 +00:00
parent ae4698230a
commit 74ee29cda3
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/org/apache/commons/logging/impl/AvalonLogger.java
View File

@@ -52,7 +52,7 @@ import org.apache.commons.logging.Log;
public class AvalonLogger implements Log { public class AvalonLogger implements Log {
/** Ancestral Avalon logger. */ /** Ancestral Avalon logger. */
private static Logger defaultLogger = null; private static volatile Logger defaultLogger = null;
/** Avalon logger used to perform log. */ /** Avalon logger used to perform log. */
private final transient Logger logger; private final transient Logger logger;

14
src/main/java/org/apache/commons/logging/impl/SimpleLog.java
View File

@@ -85,19 +85,19 @@ public class SimpleLog implements Log, Serializable {
static protected final String DEFAULT_DATE_TIME_FORMAT = "yyyy/MM/dd HH:mm:ss:SSS zzz"; static protected final String DEFAULT_DATE_TIME_FORMAT = "yyyy/MM/dd HH:mm:ss:SSS zzz";
/** Include the instance name in the log message? */ /** Include the instance name in the log message? */
static protected boolean showLogName = false; static volatile protected boolean showLogName = false;
/** Include the short name ( last component ) of the logger in the log /** Include the short name ( last component ) of the logger in the log
* message. Defaults to true - otherwise we'll be lost in a flood of * message. Defaults to true - otherwise we'll be lost in a flood of
* messages without knowing who sends them. * messages without knowing who sends them.
*/ */
static protected boolean showShortName = true; static volatile protected boolean showShortName = true;
/** Include the current time in the log message */ /** Include the current time in the log message */
static protected boolean showDateTime = false; static volatile protected boolean showDateTime = false;
/** The date and time format to use in the log message */ /** The date and time format to use in the log message */
static protected String dateTimeFormat = DEFAULT_DATE_TIME_FORMAT; static volatile protected String dateTimeFormat = DEFAULT_DATE_TIME_FORMAT;
/** /**
* Used to format times. * Used to format times.
@@ -187,11 +187,11 @@ public class SimpleLog implements Log, Serializable {
// ------------------------------------------------------------- Attributes // ------------------------------------------------------------- Attributes
/** The name of this simple log instance */ /** The name of this simple log instance */
protected String logName = null; protected volatile String logName = null;
/** The current log level */ /** The current log level */
protected int currentLogLevel; protected volatile int currentLogLevel;
/** The short name of this simple log instance */ /** The short name of this simple log instance */
private String shortLogName = null; private volatile String shortLogName = null;
// ------------------------------------------------------------ Constructor // ------------------------------------------------------------ Constructor