Normalize array type declarations

src/main/java/org/apache/commons/logging/impl/Jdk14Logger.java

@@ -72,7 +72,7 @@ public class Jdk14Logger implements Log, Serializable {
         if (logger.isLoggable(level)) {
             // Hack (?) to get the stack trace.
             final Throwable dummyException = new Throwable();
-            final StackTraceElement locations[] = dummyException.getStackTrace();
+            final StackTraceElement[] locations = dummyException.getStackTrace();
             // LOGGING-132: use the provided logger name instead of the class name
             final String cname = name;
             String method = "unknown";

src/main/java/org/apache/commons/logging/impl/LogFactoryImpl.java

@@ -209,7 +209,7 @@ public class LogFactoryImpl extends LogFactory {
     /**
      * The signature of the Constructor to be used.
      */
-    protected Class logConstructorSignature[] = { java.lang.String.class };
+    protected Class[] logConstructorSignature = { java.lang.String.class };
 
     /**
      * The one-argument {@code setLogFactory} method of the selected
@@ -220,7 +220,7 @@ public class LogFactoryImpl extends LogFactory {
     /**
      * The signature of the {@code setLogFactory} method to be used.
      */
-    protected Class logMethodSignature[] = { LogFactory.class };
+    protected Class[] logMethodSignature = { LogFactory.class };
 
     /**
      * See getBaseClassLoader and initConfiguration.
@@ -555,12 +555,12 @@ public class LogFactoryImpl extends LogFactory {
                 instance = discoverLogImplementation(name);
             }
             else {
-                final Object params[] = { name };
+                final Object[] params = { name };
                 instance = (Log) logConstructor.newInstance(params);
             }
 
             if (logMethod != null) {
-                final Object params[] = { this };
+                final Object[] params = { this };
                 logMethod.invoke(instance, params);
             }
 
@@ -1335,7 +1335,7 @@ public class LogFactoryImpl extends LogFactory {
 
         boolean implementsLog = false;
         final String logInterfaceName = Log.class.getName();
-        final Class interfaces[] = badClass.getInterfaces();
+        final Class[] interfaces = badClass.getInterfaces();
         for (final Class element : interfaces) {
             if (logInterfaceName.equals(element.getName())) {
                 implementsLog = true;

src/test/java/org/apache/commons/logging/LoadTestCase.java

@@ -23,7 +23,7 @@ import junit.framework.TestCase;
  */
 public class LoadTestCase extends TestCase{
     //TODO: need some way to add service provider packages
-    static private String LOG_PCKG[] = {"org.apache.commons.logging",
+    static private String[] LOG_PCKG = {"org.apache.commons.logging",
                                         "org.apache.commons.logging.impl"};
 
     /**
@@ -61,7 +61,7 @@ public class LoadTestCase extends TestCase{
                     out.write(is.read());
                 }
 
-                final byte data[] = out.toByteArray();
+                final byte[] data = out.toByteArray();
 
                 result = super.defineClass(name, data, 0, data.length);
                 classes.put(name, result);

src/test/java/org/apache/commons/logging/jdk14/CustomConfigTestCase.java

@@ -88,14 +88,14 @@ public class CustomConfigTestCase extends DefaultConfigTestCase {
     /**
      * <p>The message levels that should have been logged.</p>
      */
-    protected Level testLevels[] =
+    protected Level[] testLevels =
     { Level.FINE, Level.INFO, Level.WARNING, Level.SEVERE, Level.SEVERE };
 
 
     /**
      * <p>The message strings that should have been logged.</p>
      */
-    protected String testMessages[] =
+    protected String[] testMessages =
     { "debug", "info", "warn", "error", "fatal" };
 
 

src/test/java/org/apache/commons/logging/jdk14/DefaultConfigTestCase.java

@@ -102,7 +102,7 @@ public class DefaultConfigTestCase extends TestCase {
                      "org.apache.commons.logging.impl.LogFactoryImpl",
                      factory.getClass().getName());
 
-        final String names[] = factory.getAttributeNames();
+        final String[] names = factory.getAttributeNames();
         assertNotNull("Names exists", names);
         assertEquals("Names empty", 0, names.length);
     }

src/test/java/org/apache/commons/logging/log4j/StandardTests.java

@@ -86,7 +86,7 @@ public abstract class StandardTests extends TestCase {
                      "org.apache.commons.logging.impl.LogFactoryImpl",
                      factory.getClass().getName());
 
-        final String names[] = factory.getAttributeNames();
+        final String[] names = factory.getAttributeNames();
         assertNotNull("Names exists", names);
         assertEquals("Names empty", 0, names.length);
     }

src/test/java/org/apache/commons/logging/logkit/StandardTestCase.java

@@ -118,7 +118,7 @@ public class StandardTestCase extends AbstractLogTest {
                      "org.apache.commons.logging.impl.LogFactoryImpl",
                      factory.getClass().getName());
 
-        final String names[] = factory.getAttributeNames();
+        final String[] names = factory.getAttributeNames();
         assertNotNull("Names exists", names);
         assertEquals("Names empty", 0, names.length);
     }

src/test/java/org/apache/commons/logging/simple/CustomConfigTestCase.java

@@ -46,14 +46,14 @@ public class CustomConfigTestCase extends DefaultConfigTestCase {
      * <p>The message levels that should have been logged.</p>
      */
     /*
-    protected Level testLevels[] =
+    protected Level[] testLevels =
     { Level.FINE, Level.INFO, Level.WARNING, Level.SEVERE, Level.SEVERE };
     */
 
     /**
      * <p>The message strings that should have been logged.</p>
      */
-    protected String testMessages[] =
+    protected String[] testMessages =
     { "debug", "info", "warn", "error", "fatal" };
 
     /**

src/test/java/org/apache/commons/logging/simple/DefaultConfigTestCase.java

@@ -124,7 +124,7 @@ public class DefaultConfigTestCase extends TestCase {
                      "org.apache.commons.logging.impl.LogFactoryImpl",
                      factory.getClass().getName());
 
-        final String names[] = factory.getAttributeNames();
+        final String[] names = factory.getAttributeNames();
         assertNotNull("Names exists", names);
         assertEquals("Names empty", 0, names.length);
     }