Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity

Removed method PathableClassLoader.getResources as in java1.4 and earlier this

Browse Source 
method is final (can't be overridden). This means changing the associated unit
test too. As getResources doesn't explicitly indicate the order in which
resources will be returned this is technically ok, though a little ugly.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209571 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Simon Kitching
2005-07-07 07:32:16 +00:00
parent d0281e782f
commit 3083b9a334
2 changed files with 23 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/test/org/apache/commons/logging/pathable/ChildFirstTestCase.java
View File

@@ -230,15 +230,21 @@ public class ChildFirstTestCase extends TestCase {
assertEquals("Unexpected number of PathableTestSuite.class resources found", 1, urls.length);
// getResources where the resource exists in both.
// resources should be returned in order (child-resource, parent-resource)
// resources should be returned in order (child-resource, parent-resource).
//
// IMPORTANT: due to the fact that in java 1.4 and earlier method
// ClassLoader.getResources is final it isn't possible for PathableClassLoader
// to override this. So even when child-first is enabled the resource order
// is still (parent-resources, child-resources). This test verifies the expected
// behaviour - even though it's not the desired behaviour.
resources = childLoader.getResources("org/apache/commons/logging/impl/Log4J12Logger.class");
urls = toURLArray(resources);
assertEquals("Unexpected number of Log4J12Logger.class resources found", 2, urls.length);
assertTrue("Incorrect source for Log4J12Logger class",
urls[0].toString().indexOf("/commons-logging-adapters-1.") > 0);
urls[0].toString().indexOf("/commons-logging-1.") > 0);
assertTrue("Incorrect source for Log4J12Logger class",
urls[1].toString().indexOf("/commons-logging-1.") > 0);
urls[1].toString().indexOf("/commons-logging-adapters-1.") > 0);
}
/**