From 2a9617af3b3021a8b7e81207285b14dac3330f5e Mon Sep 17 00:00:00 2001 From: Sebastian Bazley Date: Wed, 18 Jul 2012 18:32:49 +0000 Subject: [PATCH] Make immutable private fields final git-svn-id: https://svn.apache.org/repos/asf/commons/proper/logging/trunk@1363037 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/commons/logging/impl/AvalonLogger.java | 2 +- src/java/org/apache/commons/logging/impl/Log4JLogger.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/java/org/apache/commons/logging/impl/AvalonLogger.java b/src/java/org/apache/commons/logging/impl/AvalonLogger.java index 639aa4e..98c61f8 100644 --- a/src/java/org/apache/commons/logging/impl/AvalonLogger.java +++ b/src/java/org/apache/commons/logging/impl/AvalonLogger.java @@ -57,7 +57,7 @@ public class AvalonLogger implements Log { /** Ancesteral avalon logger */ private static Logger defaultLogger = null; /** Avalon logger used to perform log */ - private transient Logger logger = null; + private final transient Logger logger; /** * Constructs an AvalonLogger that outputs to the given diff --git a/src/java/org/apache/commons/logging/impl/Log4JLogger.java b/src/java/org/apache/commons/logging/impl/Log4JLogger.java index 4332a44..0a0e72e 100644 --- a/src/java/org/apache/commons/logging/impl/Log4JLogger.java +++ b/src/java/org/apache/commons/logging/impl/Log4JLogger.java @@ -58,7 +58,7 @@ public class Log4JLogger implements Log, Serializable { private transient Logger logger = null; /** Logger name */ - private String name = null; + private final String name; private static final Priority traceLevel; @@ -100,6 +100,7 @@ public class Log4JLogger implements Log, Serializable { // ------------------------------------------------------------ Constructor public Log4JLogger() { + name = null; }