Siphalor/tweed5-commons-logging
1
0
Fork 0
Code Activity

Improved diagnostic message by adding quotes.

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@377235 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Robert Burrell Donkin
2006-02-12 20:23:13 +00:00
parent 6b8f983f0d
commit 271a6784d2
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/java/org/apache/commons/logging/impl/LogFactoryImpl.java
View File

@@ -1349,8 +1349,8 @@ public class LogFactoryImpl extends LogFactory {
try { try {
ClassLoader logInterfaceClassLoader = getClassLoader(Log.class); ClassLoader logInterfaceClassLoader = getClassLoader(Log.class);
logDiagnostic( logDiagnostic(
"Class " + badClass.getName() "Class '" + badClass.getName()
+ " was found in classloader " + "' was found in classloader "
+ objectId(badClassLoader) + objectId(badClassLoader)
+ ". It is bound to a Log interface which is not" + ". It is bound to a Log interface which is not"
+ " the one loaded from classloader " + " the one loaded from classloader "
@@ -1358,7 +1358,7 @@ public class LogFactoryImpl extends LogFactory {
} catch (Throwable t) { } catch (Throwable t) {
logDiagnostic( logDiagnostic(
"Error while trying to output diagnostics about" "Error while trying to output diagnostics about"
+ " bad class " + badClass); + " bad class '" + badClass + "'");
} }
} }
@@ -1366,9 +1366,9 @@ public class LogFactoryImpl extends LogFactory {
StringBuffer msg = new StringBuffer(); StringBuffer msg = new StringBuffer();
msg.append("Terminating logging for this context "); msg.append("Terminating logging for this context ");
msg.append("due to bad log hierarchy. "); msg.append("due to bad log hierarchy. ");
msg.append("You have more than one version of "); msg.append("You have more than one version of '");
msg.append(Log.class.getName()); msg.append(Log.class.getName());
msg.append(" visible."); msg.append("' visible.");
if (isDiagnosticsEnabled()) { if (isDiagnosticsEnabled()) {
logDiagnostic(msg.toString()); logDiagnostic(msg.toString());
} }
@@ -1378,9 +1378,9 @@ public class LogFactoryImpl extends LogFactory {
if (isDiagnosticsEnabled()) { if (isDiagnosticsEnabled()) {
StringBuffer msg = new StringBuffer(); StringBuffer msg = new StringBuffer();
msg.append("Warning: bad log hierarchy. "); msg.append("Warning: bad log hierarchy. ");
msg.append("You have more than one version of "); msg.append("You have more than one version of '");
msg.append(Log.class.getName()); msg.append(Log.class.getName());
msg.append(" visible."); msg.append("' visible.");
logDiagnostic(msg.toString()); logDiagnostic(msg.toString());
} }
} else { } else {
@@ -1388,9 +1388,9 @@ public class LogFactoryImpl extends LogFactory {
if (!allowFlawedDiscovery) { if (!allowFlawedDiscovery) {
StringBuffer msg = new StringBuffer(); StringBuffer msg = new StringBuffer();
msg.append("Terminating logging for this context. "); msg.append("Terminating logging for this context. ");
msg.append("Log class "); msg.append("Log class '");
msg.append(badClass.getName()); msg.append(badClass.getName());
msg.append(" does not implement the Log interface."); msg.append("' does not implement the Log interface.");
if (isDiagnosticsEnabled()) { if (isDiagnosticsEnabled()) {
logDiagnostic(msg.toString()); logDiagnostic(msg.toString());
} }
@@ -1400,9 +1400,9 @@ public class LogFactoryImpl extends LogFactory {
if (isDiagnosticsEnabled()) { if (isDiagnosticsEnabled()) {
StringBuffer msg = new StringBuffer(); StringBuffer msg = new StringBuffer();
msg.append("Warning: Log class "); msg.append("[WARNING] Log class '");
msg.append(badClass.getName()); msg.append(badClass.getName());
msg.append(" does not implement the Log interface."); msg.append("' does not implement the Log interface.");
logDiagnostic(msg.toString()); logDiagnostic(msg.toString());
} }
} }