1
0

Remove unused constructor

Set necessary System properties in code rather than assuming build.xml will set them.
Call LogFactory.releaseAll before each test for cleanliness.


git-svn-id: https://svn.apache.org/repos/asf/jakarta/commons/proper/logging/trunk@209451 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Simon Kitching
2005-07-06 12:09:58 +00:00
parent 35b1d6c80e
commit 2649aa8c6d

View File

@@ -24,6 +24,7 @@ import java.util.List;
import junit.framework.Test; import junit.framework.Test;
import junit.framework.TestSuite; import junit.framework.TestSuite;
import org.apache.commons.logging.LogFactory;
import org.apache.commons.logging.impl.SimpleLog; import org.apache.commons.logging.impl.SimpleLog;
@@ -37,19 +38,6 @@ import org.apache.commons.logging.impl.SimpleLog;
public class CustomConfigTestCase extends DefaultConfigTestCase { public class CustomConfigTestCase extends DefaultConfigTestCase {
// ----------------------------------------------------------- Constructors
/**
* <p>Construct a new instance of this test case.</p>
*
* @param name Name of the test case
*/
public CustomConfigTestCase(String name) {
super(name);
}
// ----------------------------------------------------- Instance Variables // ----------------------------------------------------- Instance Variables
@@ -77,11 +65,26 @@ public class CustomConfigTestCase extends DefaultConfigTestCase {
// ------------------------------------------- JUnit Infrastructure Methods // ------------------------------------------- JUnit Infrastructure Methods
/**
* Set system properties that will control the LogFactory/Log objects
* when they are created. Subclasses can override this method to
* define properties that suit them.
*/
public void setProperties() {
System.setProperty(
"org.apache.commons.logging.Log",
"org.apache.commons.logging.simple.DecoratedSimpleLog");
System.setProperty(
"org.apache.commons.logging.simplelog.defaultlog",
"debug");
}
/** /**
* Set up instance variables required by this test case. * Set up instance variables required by this test case.
*/ */
public void setUp() throws Exception { public void setUp() throws Exception {
LogFactory.releaseAll();
setProperties();
expected = new ArrayList(); expected = new ArrayList();
setUpFactory(); setUpFactory();
setUpLog("DecoratedLogger"); setUpLog("DecoratedLogger");