From 1807d469fe80f688c66068f4a00b85be8b632db1 Mon Sep 17 00:00:00 2001 From: "Gary D. Gregory" Date: Sun, 13 Jan 2013 04:39:40 +0000 Subject: [PATCH] Add final modifier to private fields. git-svn-id: https://svn.apache.org/repos/asf/commons/proper/logging/trunk@1432548 13f79535-47bb-0310-9956-ffa450edef68 --- src/test/org/apache/commons/logging/PathableTestSuite.java | 2 +- src/test/org/apache/commons/logging/jdk14/TestHandler.java | 2 +- .../org/apache/commons/logging/log4j/log4j12/TestAppender.java | 2 +- .../apache/commons/logging/security/MockSecurityManager.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/org/apache/commons/logging/PathableTestSuite.java b/src/test/org/apache/commons/logging/PathableTestSuite.java index 054d2d0..4be9302 100644 --- a/src/test/org/apache/commons/logging/PathableTestSuite.java +++ b/src/test/org/apache/commons/logging/PathableTestSuite.java @@ -109,7 +109,7 @@ public class PathableTestSuite extends TestSuite { * The classloader that should be set as the context classloader * before each test in the suite is run. */ - private ClassLoader contextLoader; + private final ClassLoader contextLoader; /** * Constructor. diff --git a/src/test/org/apache/commons/logging/jdk14/TestHandler.java b/src/test/org/apache/commons/logging/jdk14/TestHandler.java index 2870886..06ecfce 100644 --- a/src/test/org/apache/commons/logging/jdk14/TestHandler.java +++ b/src/test/org/apache/commons/logging/jdk14/TestHandler.java @@ -39,7 +39,7 @@ public class TestHandler extends Handler { // The set of logged records for this handler - private List records = new ArrayList(); + private final List records = new ArrayList(); // --------------------------------------------------------- Public Methods diff --git a/src/test/org/apache/commons/logging/log4j/log4j12/TestAppender.java b/src/test/org/apache/commons/logging/log4j/log4j12/TestAppender.java index 0ffc086..649306f 100644 --- a/src/test/org/apache/commons/logging/log4j/log4j12/TestAppender.java +++ b/src/test/org/apache/commons/logging/log4j/log4j12/TestAppender.java @@ -44,7 +44,7 @@ public class TestAppender extends AppenderSkeleton { // The set of logged events for this appender - private List events; + private final List events; // ------------------------------------------------------- Appender Methods diff --git a/src/test/org/apache/commons/logging/security/MockSecurityManager.java b/src/test/org/apache/commons/logging/security/MockSecurityManager.java index 2f7f419..2c74870 100644 --- a/src/test/org/apache/commons/logging/security/MockSecurityManager.java +++ b/src/test/org/apache/commons/logging/security/MockSecurityManager.java @@ -30,7 +30,7 @@ import java.security.Permissions; */ public class MockSecurityManager extends SecurityManager { - private Permissions permissions = new Permissions(); + private final Permissions permissions = new Permissions(); private static final Permission setSecurityManagerPerm = new RuntimePermission("setSecurityManager");